Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Gateway.NoFetch applies fully #5929

Closed
4 of 5 tasks
magik6k opened this issue Jan 18, 2019 · 0 comments
Closed
4 of 5 tasks

Make sure Gateway.NoFetch applies fully #5929

magik6k opened this issue Jan 18, 2019 · 0 comments
Labels
help wanted Seeking public contribution on this issue topic/core-api Topic core-api topic/gateway Topic gateway

Comments

@magik6k
Copy link
Member

magik6k commented Jan 18, 2019

#5649 implemented Gateway.NoFetch option and applies it to /api by using global offline coreapi option. This means that read-only commands which don't yet use coreapi aren't covered and need to be converted:

From #5649 (comment):

  • /get - will be hard to port, there is a lot of code surrounding it which will need to be tamed. - Refactor ipfs get to use CoreAPI #5943
  • /dns - needs to get into coreapi (probably under .Name()) (doesn't really need to be covered)
  • /ls - Can be rewritten to use coreapi, but that's going to be quite hard (it can be worked around manually for now)
  • /dag/get - needs to be ported to coreapi
  • /dag/resolve - same as above
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue topic/core-api Topic core-api topic/gateway Topic gateway
Projects
None yet
Development

No branches or pull requests

1 participant