Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coreunix: addFile: encapsulate FlushMemFree call #5060

Open
schomatis opened this issue Jun 1, 2018 · 0 comments
Open

coreunix: addFile: encapsulate FlushMemFree call #5060

schomatis opened this issue Jun 1, 2018 · 0 comments
Labels
topic/docs-ipfs Topic docs-ipfs topic/files Topic files

Comments

@schomatis
Copy link
Contributor

The addFile functions is pretty much the entry point for anyone looking to understand what is going on when calling ipfs add so it would be useful to keep it as clean as possible, I think the flush logic added in #3888 could be encapsulated in a separate function.

https://github.com/ipfs/go-ipfs/blob/7853e53860805e08a212d78c4baa5d59bff99ba8/core/coreunix/add.go#L421-L439

(Also we could make liveCacheSize a const and document its use and the value chosen.)
@schomatis schomatis changed the title coreunix: encapsulate FlushMemFree call coreunix: addFile: encapsulate FlushMemFree call Jun 1, 2018
@schomatis schomatis self-assigned this Jun 1, 2018
@schomatis schomatis added topic/files Topic files topic/docs-ipfs Topic docs-ipfs labels Jun 1, 2018
@schomatis schomatis added this to the Files API Documentation milestone Jun 1, 2018
@Stebalien Stebalien removed this from the Files API Documentation milestone Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic/docs-ipfs Topic docs-ipfs topic/files Topic files
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @schomatis