Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a WebSockets listener to the default config #4093

Closed
daviddias opened this issue Jul 27, 2017 · 7 comments
Closed

Add a WebSockets listener to the default config #4093

daviddias opened this issue Jul 27, 2017 · 7 comments

Comments

@daviddias
Copy link
Member

It reduces one config step to new users.

@Kubuxu
Copy link
Member

Kubuxu commented Jul 27, 2017

It won't work by default either way because it is not wss it is ws.

@daviddias
Copy link
Member Author

daviddias commented Jul 27, 2017

@Kubuxu "It won't work" if the user is dialing from a webpage that was loaded behind https. It will work in:

  • localhost
  • IP
  • any http page
  • from node.js

It will reduce one config step.

@whyrusleeping
Copy link
Member

Maybe we can just add an init profile with websockets enabled by default.

@ghost
Copy link

ghost commented Jul 31, 2017

A /ws listener by default would help integrating with in-browser local discovery through FlyWeb -- the details around https need to be figured out though (whether it's needed, etc.)

@alvin-reyes
Copy link
Contributor

Did we have any updates on this? Any follow thru if this was implemented? Thanks.

@Stebalien
Copy link
Member

Once we fix libp2p/go-ws-transport#21, I think we should be good to go.

@magik6k
Copy link
Member

magik6k commented May 14, 2019

PR in go-ipfs-config - ipfs/go-ipfs-config#24

Closing this issue as there is also #5251 which tracks this too

@magik6k magik6k closed this as completed May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants