Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: rename ipfs/go-ipfs:latest and/or add a latest stable image #2888

Closed
chpio opened this issue Jun 21, 2016 · 9 comments
Closed

docker: rename ipfs/go-ipfs:latest and/or add a latest stable image #2888

chpio opened this issue Jun 21, 2016 · 9 comments
Labels
kind/bug A bug in existing code (including security flaws) topic/containers + vms

Comments

@chpio
Copy link

chpio commented Jun 21, 2016

should be declared as the dev build. i assumed it's the latest working build, but it's not ;(


so i switched to an versioned image, but that's also not nice:

  1. the base image isn't updating (the last versioned was built 2 a moths ago)
  2. i have to track the versions (can't do a simple docker-compose pull & systemctl restart ipfs by hand or automatically)

it would be good that...

  • the latest image would be named develop or something
  • there would be a latest (call it stable or something) stable image
@chpio chpio changed the title docker: rename ipfs:latest and/or add a latest stable image docker: rename ipfs/go-ipfs:latest and/or add a latest stable image Jun 21, 2016
@whyrusleeping
Copy link
Member

@chpio what is breaking on the latest docker image?

@chpio
Copy link
Author

chpio commented Jun 22, 2016

it was throwing an Argument 'key' is required on an add call, dunno what is causing it exactly (im using js-ipfs-api). after switching to 0.4.2 build it went away. ipfs-inactive/js-ipfs-http-client#302

@whyrusleeping whyrusleeping added the kind/bug A bug in existing code (including security flaws) label Jun 23, 2016
@whyrusleeping whyrusleeping added the help wanted Seeking public contribution on this issue label Aug 23, 2016
@whyrusleeping
Copy link
Member

cc @lgierth

@ghost ghost added topic/containers + vms and removed help wanted Seeking public contribution on this issue labels Aug 23, 2016
@ghost ghost self-assigned this Aug 23, 2016
@ghost
Copy link

ghost commented Aug 26, 2016

Done, the images are being rebuilt right now: https://hub.docker.com/r/ipfs/go-ipfs/builds/

@ghost ghost closed this as completed Aug 26, 2016
@ghost
Copy link

ghost commented Aug 26, 2016

This is now consistent with the original naming in jbenet/go-ipfs: latest=release-branch, release=release-branch, master=master-branch

@chpio
Copy link
Author

chpio commented Sep 23, 2016

still broken:
screenshot

@ghost
Copy link

ghost commented Sep 23, 2016

woops, thanks for raising this again - we forgot to push v0.4.3 to the release branch, which that image is based off. doing that now.

@ghost
Copy link

ghost commented Sep 23, 2016

reopening this issue because pushing to the release branch just triggered a build of the "latest" image... :S

@ghost ghost reopened this Sep 23, 2016
@chpio
Copy link
Author

chpio commented Sep 23, 2016

also it isn't rebuilding on alpine updates, this should be fixed also

@chpio chpio closed this as completed Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) topic/containers + vms
Projects
None yet
Development

No branches or pull requests

2 participants