Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic in go tests (mfs_test.go) #2361

Closed
whyrusleeping opened this issue Feb 18, 2016 · 4 comments
Closed

panic in go tests (mfs_test.go) #2361

whyrusleeping opened this issue Feb 18, 2016 · 4 comments
Labels
topic/test failure Topic test failure

Comments

@whyrusleeping
Copy link
Member

https://travis-ci.org/ipfs/go-ipfs/jobs/109692258

@whyrusleeping
Copy link
Member Author

@chriscool
Copy link
Contributor

@whyrusleeping the commit that is tested in the build that failed again is edfac54 which merges ac42bb7 into f8eefba

@noffle's commit that fixes the problem is hackergrrl@2c4de53 and it is not reached by any of the above commits.

Looking at the graph:

* |   65cda02 Merge pull request #2367 from ipfs/docs/capitalize-dht
|\ \  
| * | ac42bb7 Capitalized DHT
| |/  
* |   9cdb69c Merge pull request #2365 from noffle/length_zero
|\ \  
| * | 2c4de53 Fixes range error by using > 0 length buffer.
| |/  
* |   944f749 Merge pull request #2369 from ipfs/docs/get-command
|\ \  
| |/  
|/|   
| * 50a44f9 Added ticks, `the`, and defaults to `get`
|/  
*   f8eefba Merge pull request #2354 from ipfs/fix/stdin-arg-parse

we can see the related commits have been merged without being rebased first.

So I believe @noffle's fix is correct.

@whyrusleeping
Copy link
Member Author

ah, okay. sounds good to me

@chriscool
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/test failure Topic test failure
Projects
None yet
Development

No branches or pull requests

2 participants