Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory datastore config setting would be nice #1366

Closed
whyrusleeping opened this issue Jun 12, 2015 · 8 comments
Closed

memory datastore config setting would be nice #1366

whyrusleeping opened this issue Jun 12, 2015 · 8 comments
Labels
exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature topic/repo Topic repo

Comments

@whyrusleeping
Copy link
Member

We used to be able to specify in the config to use an 'in memory' datastore. This would be nice to have again for testing various things.

@whyrusleeping whyrusleeping added kind/enhancement A net-new feature or improvement to an existing feature topic/repo Topic repo labels Jun 12, 2015
@jbenet
Copy link
Member

jbenet commented Jun 12, 2015

👍

@jbenet jbenet mentioned this issue Jun 16, 2015
55 tasks
@whyrusleeping
Copy link
Member Author

I have some basic code for this here: https://github.com/ipfs/go-ipfs/tree/feat/config-ds

But its probably best to wait on the s3 datastore changes.

@Stebalien Stebalien added help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors labels Jan 24, 2019
@Stebalien
Copy link
Member

We now have support for custom datastore configs and plugins. This should now be pretty trivial to implement if anyone wants to pick it up. You may find the following example useful: https://github.com/ipfs/go-ipfs-example-plugin/

@cfdair
Copy link

cfdair commented Jan 30, 2019

I'll have a crack.

@Stebalien
Copy link
Member

Actually, it looks like we support this without any additional plugins. We just need to create a config profile for the "mem" datastore: https://github.com/ipfs/go-ipfs-config/blob/master/profile.go.

@magik6k
Copy link
Member

magik6k commented Feb 28, 2019

Note that using memory datastore may break between restarts in weird ways:

  • if used for entire datastore, it probably won't even start because of missing pinroot/filesroot
  • if only used for blocks, pinning will not be happy. MFS may also break

(this should be fixable, but we have to be careful when fixing pinning)

@ef3n9r98
Copy link

Hey! Did someone end up fixing this issue? And if not, would you be willing to compensate a dev for fixing it (even if it's small)?

@Jorropo
Copy link
Contributor

Jorropo commented Jul 27, 2023

There is support here:

"mem": MemDatastoreConfig,

I'll close this given I don't see anything left to do, can reopen if I missed something obviously.

@Jorropo Jorropo closed this as completed Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature topic/repo Topic repo
Projects
None yet
Development

No branches or pull requests

7 participants