Skip to content

Commit

Permalink
update comment to note that we're punting on this
Browse files Browse the repository at this point in the history
License: MIT
Signed-off-by: Steven Allen <[email protected]>
  • Loading branch information
Stebalien committed Jan 29, 2018
1 parent 87c6914 commit 2379aa0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions blockservice/blockservice.go
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ func (s *blockService) AddBlock(o blocks.Block) error {
}

if err := s.exchange.HasBlock(o); err != nil {
// TODO(stebalien): really an error?
// TODO(#4623): really an error?
return errors.New("blockservice is closed")
}

Expand Down Expand Up @@ -170,7 +170,7 @@ func (s *blockService) AddBlocks(bs []blocks.Block) error {

for _, o := range toput {
if err := s.exchange.HasBlock(o); err != nil {
// TODO(stebalien): Should this really *return*?
// TODO(#4623): Should this really *return*?
return fmt.Errorf("blockservice is closed (%s)", err)
}
}
Expand Down

0 comments on commit 2379aa0

Please sign in to comment.