Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests, or skip with brokenDuringKuboRpcClientMigration if significant effort is required #53

Closed
SgtPooki opened this issue Oct 14, 2022 · 1 comment
Closed

Fix tests, or skip with brokenDuringKuboRpcClientMigration if significant effort is required #53

SgtPooki opened this issue Oct 14, 2022 · 1 comment

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Oct 14, 2022 •
edited
Loading

...[ '.dht.put', 'should put a value to the DHT', '.dht.get', 'should respect timeout option when getting a value from the DHT' ].map((name) => ({ reason: brokenDuringKuboRpcClientMigration, name }))

For failing tests that do not have simple and obvious fixes, I will disable them in test/interface-tests.spec.js, so that CI is passing and Kubo team can take over to handle the more complex use cases, while I can get back to working on ipfs-webui dependency issues.
@SgtPooki SgtPooki mentioned this issue Oct 14, 2022
Closed
2 tasks
@SgtPooki SgtPooki changed the title Fix tests, or skip with js-kubo-rpc-client/test/constants.js Line 25 in c899abb const brokenDuringKuboRpcClientMigration = () => true if significant effort is required Fix tests, or skip with brokenDuringKuboRpcClientMigration if significant effort is required Oct 17, 2022
@SgtPooki SgtPooki moved this to To do in IPFS-GUI (PL EngRes) Oct 17, 2022
@SgtPooki SgtPooki moved this from To do to In progress in IPFS-GUI (PL EngRes) Oct 17, 2022
@SgtPooki
Copy link
Member Author

superseded by #56

Repository owner moved this from In progress to Done in IPFS-GUI (PL EngRes) Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
IPFS-GUI (PL EngRes)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SgtPooki