Connect to already running daemon

[hacdias]

After talking to @dryajov, we noticed that ipfsd-ctl doesn't connect to already running daemons. This code:

DaemonFactory.create().spawn({
  repoPath: "/a/beautiful/path",
  disposable: false,
  init: false,
  start: false
}, (err, node) => { console.log(node.started) })

Should print true if the there was a daemon on that repo and node.api should be populated. 😄

[daviddias]

@hacdias this is only on the latest version that hasn't been merged right? Namely #176 ? Was this a feature that you use in the current released version? If so it is a regression and #176 shouldn't be merged until it is fixed.

@hacdias can you add a test for it on the PR?

[hacdias]

@diasdavid I don't know if the current version can connect to already running daemons. I have tried but it didn't seem to work neither with master, nor with #176

[dryajov]

@diasdavid this functionality wasn't present in the previous versions either.

[daviddias]

Ok, no blocker then :)

[hacdias]

Any progresses on this @dryajov? If you didn't start, I can try to look at the code and see what I can do.

[dryajov]

Go for it - I haven't been able to get to it yet.

[daviddias]

@hacdias 👍 for me as well. Definitely make sure to create a good error for in-proc nodes given that there is no way for two clients to connect to it.

[dryajov]

@hacdias have you already started on this, if not I can give it a go now.

[hacdias]

@dryajov no, I haven't. Sorry for the late response.

[dryajov]

I just did - #221

[daviddias]

👏🏽👏🏽