This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Add blob-stores to deps instead of devDeps #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks :) can you please change the commit message to follow our convention? sth like |
|
@dignifiedquire ah, of course! Forgot... We should have a post-commit lint for that! |
victorb
force-pushed
the
add-blob-stores-to-deps
branch
from
4913018 to
da205f8
Compare
|
@dignifiedquire commit msg fixed! |
|
lgtm |
|
Sorry @victorbjelkholm could you rebase onto |
|
@victorbjelkholm can you add this -- #502 (comment) -- as a feature request for aegir? |
We depend on these in the application and they are needed to run
victorb
force-pushed
the
add-blob-stores-to-deps
branch
from
da205f8 to
8f33d11
Compare
|
@dignifiedquire rebased! \o/ @diasdavid Opened! ipfs/aegir#59 |
|
thank you @victorbjelkholm :) |
MicrowaveDev
pushed a commit
to galtproject/js-ipfs
that referenced
this pull request
May 22, 2020
License: MIT Signed-off-by: Alan Shaw <[email protected]>
This was referenced Apr 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We depend on these in the application and they are needed to run
js-ipfs/src/core/default-repo/node.js
Line 4 in 1c64247
js-ipfs/src/cli/commands/init.js
Line 5 in 37db11e
js-ipfs/src/core/default-repo/browser.js
Line 3 in 1c64247