This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Make ipfs.files.add return DAGNodes #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackergrrl
changed the title
| i.once('end', () => { | ||
| // Transform file info tuples to DAGNodes | ||
| i.pipe(through.obj(function transform (info, enc, next) { | ||
| console.log('info', info) |
There was a problem hiding this comment.
Why console log in the core? What spec does this follow? Same for L31
There was a problem hiding this comment.
Whoops -- debugging leftovers.
hackergrrl
force-pushed
the
files-add-dagnode
branch
from
2dac5eb
to
be926ba
Compare
|
This PR blocked on major release on https://github.com/ipfs/js-ipfs-unixfs-engine and merge of ipfs-inactive/interface-js-ipfs-core#20. Please don't merge until all is green. :) |
|
hackergrrl
force-pushed
the
files-add-dagnode
branch
from
be926ba
to
11a9b62
Compare
Though one of these is a fix (using 'before' properly), the rest are timing issues that are more noticeable on slower computers.
hackergrrl
force-pushed
the
files-add-dagnode
branch
from
11a9b62
to
7b698b3
Compare
|
Just waiting on ipfs-inactive/interface-js-ipfs-core#20 to get merged + published and we're good to go! |
|
Did you check browser tests? Just ran them and got: |
|
I got the same result when testing the interface-core tests through js-ipfs-api yesterday. |
|
that's a bug in brfs browserify/brfs#40 |
|
@diasdavid sorry could you please share more information before closing a PR? |
This was referenced Jan 9, 2021
This was referenced Jan 21, 2022
This was referenced Mar 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DAGNodesNOTE: this breaks backwards compatibility for
addand will require a major semver bump.