ping tests are failing

[daviddias]

  1) HTTP API
       ## http-api spec tests
         /ping
           returns 200 and the response stream with the ping result:
     Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/imp/code/js-ipfs/test/node.js)


  2) HTTP API
       ## http-api spec tests
         /pubsub
           /peers
             returns 200 if no topic is provided:
     Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/imp/code/js-ipfs/test/node.js)


  3) interface-ipfs-core over ipfs-api tests
       .ping
         should fail when pinging an unknown peer:
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/imp/code/js-ipfs/test/node.js)


  4) interface-ipfs-core over ipfs-api tests
       .ping
         should fail when pinging an invalid peer:
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/imp/code/js-ipfs/test/node.js)


  5) interface-ipfs-core over ipfs-api tests
       .pingPullStream
         should fail when pinging an unknown peer over pull stream:
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/imp/code/js-ipfs/test/node.js)


  6) interface-ipfs-core over ipfs-api tests
       .pingPullStream
         should fail when pinging an invalid peer over pull stream:
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/imp/code/js-ipfs/test/node.js)


  7) interface-ipfs-core over ipfs-api tests
       .pingReadableStream
         should fail when pinging an unknown peer over readable stream:
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/imp/code/js-ipfs/test/node.js)


  8) interface-ipfs-core over ipfs-api tests
       .pingReadableStream
         should fail when pinging an invalid peer over readable stream:
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/imp/code/js-ipfs/test/node.js)

this is blocking the release #1635

[daviddias]

I've tested with the latest libp2p (version on master) and it doesn't seem to solve the problem (which means we don't have a need to accelerate the libp2p release libp2p/js-libp2p#249).

Note, the ping tests only fail when it is ipfs-api contacting the http-api, so we have indeed narrowed down the issue to the http-api / ipfs-api implementation detail.

[daviddias]

fix is here #1685