pubsub/peers topic is optional

[richardschneider]

According to the docs the topic argument is optional in pubsub/peers.

js-ipfs makes it mandatory.

[daviddias]

Good catch. Open for contribs!

[haoliangyu]

I can work on this issue.

Another place that (maybe) needs change is here where topic is used to filter the peers to return. If the topic is optional, the filtering could be skipped based on the value of topic.

Since the topic is optional, do you want to keep the pubshub.peers(topic, callback) pattern even the topic is nullable, or allow pubshub.peers(callback) when topic is undefined?

Please advice.

[richardschneider]

@haoliangyu Good analysis. I like having two method signatures

• pubsub.peers (callback)
• pubsub.peers (topic, callback)