Version up breaks many tests in other packages

[richardschneider]

Other packages that use a IPFS repo in a test fixture, for example js-ipfs-bitswap, now break with the commit and generate the following error

Error: version mismatch: expected v6, found v5
      at get (node_modules\ipfs-repo\src\version.js:57:27)
      at store.get (node_modules\ipfs-repo\src\version.js:31:9)
      at node_modules\graceful-fs\graceful-fs.js:78:16
      at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:513:3)

The issue is the version number. The repo in a test fixture has a version number of 5. But this new code requires version 6. Why?

If there is a real difference between 5 and 6, then the package should gracefully upgrade the database.

[richardschneider]

I have go-ipfs version 0.4.7 installed on my machine, When I run js-ipfs, via node src/cli/bin.js I get the version mismatch error.

So this means that js-ipfs is NOT interop with go-ipfs!

[richardschneider]

Perhaps the version number check can just be removed. See the code

[daviddias]

Answered here ipfs/js-ipfs-bitswap#154 (comment)

This needs to be solved by writing the spec and implementing compliance tests. Until then, we are in this weird situation.

Just to make sure that no wrong claims are broadcasted. js-ipfs does interop with go-ipfs, in fact:

• js-ipfs can use a go-ipfs generated repo just fine
• js-ipfs can talk with a go-ipfs nodes and fetch files

[richardschneider]

So the current fix is to edit the version file and change the "5" to "6",

[daviddias]

Yes. I believe we have fixed them all now