Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port tests from go-bitswap #9

Closed
dignifiedquire opened this issue May 5, 2016 · 6 comments
Closed

Port tests from go-bitswap #9

dignifiedquire opened this issue May 5, 2016 · 6 comments
Assignees
@pgte
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue P0 Critical: Tackled by core team ASAP

Comments

@dignifiedquire
Copy link
Member

We want all these tests ported: https://github.com/ipfs/go-ipfs/blob/master/exchange/bitswap/bitswap_test.go

Depends on #8
@dignifiedquire dignifiedquire self-assigned this May 5, 2016
@dignifiedquire dignifiedquire added kind/support A question or request for support tests and removed kind/support A question or request for support labels May 5, 2016
@daviddias
Copy link
Member

We have a script to spawn a network of bitswap nodes. Anything else missing to make this happen?

@dignifiedquire
Copy link
Member Author

There are some more unit tests inside that I wanted to be in here go-bitswap

@daviddias
Copy link
Member

Sounds great to me :) tests tests tests :D

@dignifiedquire
Copy link
Member Author

Moving this to milestone 5 when we have routing enabled, makes more sense to do the testing then.

@daviddias daviddias self-assigned this Oct 31, 2016
@daviddias daviddias added status/in-progress In progress and removed js-ipfs-ready labels Oct 31, 2016
@daviddias daviddias added status/ready Ready to be worked and removed status/in-progress In progress labels Dec 5, 2016
@daviddias daviddias removed the tests label Dec 7, 2016
@daviddias daviddias added status/deferred Conscious decision to pause or backlog and removed status/ready Ready to be worked labels Jan 29, 2017
@daviddias daviddias added status/ready Ready to be worked P0 Critical: Tackled by core team ASAP exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue and removed status/deferred Conscious decision to pause or backlog status/ready Ready to be worked labels Oct 17, 2017
@pgte pgte self-assigned this Nov 23, 2017
@daviddias daviddias added status/in-progress In progress and removed status/ready Ready to be worked labels Nov 23, 2017
@pgte
Copy link
Contributor

pgte commented Nov 28, 2017

From my read, go tests create a virtual network with a fixed delay.
Currently, js-ipfs-bitswap tests use the TCP transport.
Should these new tests use a virtual network with similar characteristics?
If so, is there anything in place?

@pgte pgte mentioned this issue Nov 29, 2017
Merged
@daviddias
Copy link
Member

Work happening here #159

@ghost ghost removed the status/in-progress In progress label Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgte pgte

Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue P0 Critical: Tackled by core team ASAP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pgte @dignifiedquire @daviddias