Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish GIT Revision of running build #842

Closed
lidel opened this issue Oct 1, 2018 · 8 comments
Closed

Publish GIT Revision of running build #842

lidel opened this issue Oct 1, 2018 · 8 comments
Labels
P1 High: Likely tackled by core team if no one steps up

Comments

@lidel
Copy link
Member

lidel commented Oct 1, 2018

Right now we are unable to tell what build is running, which will make bug reporting a real problem.

It would be extremely useful to:

  • At least put it in meta header (example)
  • Additionally, put a faded-out version somewhere in Settings screen, or near 'See source'/'Report a bug', so it is visible on screenshots and/or non-technical user is able to check it and provide it with a bug report

This needs to happen before we ask general public for feedback.

Eg.

@lidel lidel added the P1 High: Likely tackled by core team if no one steps up label Oct 1, 2018
@fsdiogo
Copy link
Contributor

fsdiogo commented Oct 1, 2018

This is great @lidel 👌

Here's a thought, as we have the running daemon version, why not have the WebUI version there too:

version

@lidel
Copy link
Member Author

lidel commented Oct 1, 2018

Hm.. I'd rather not put it there: webui version is not really a part of "node info".

What if we add it above links added in #809 (comment) ?
To save space, the git hash (git rev-parse --short HEAD) could double as a link to sources at github eg:
See sources: 1e2c58fe

@fsdiogo
Copy link
Contributor

fsdiogo commented Oct 1, 2018

webui version is not really a part of "node info".

Yeah, you're right.

What if we add it above links added in #809 (comment)?

That could work, although personally I wouldn't want that info showing all the time. I'd prefer as you said somewhere in Settings. Or in the status page maybe?

@fsdiogo
Copy link
Contributor

fsdiogo commented Oct 1, 2018

Well, something along these lines doesn't shock me!

rev

@olizilla
Copy link
Member

olizilla commented Oct 1, 2018

Very cool! What if we go more subtle and replace "see the code" with the revision number?

@fsdiogo
Copy link
Contributor

fsdiogo commented Oct 2, 2018

I have mixed feelings about that 🤔

For one I like it because it would have -1 link. On the other hand, it's not very clear for the average user that the revision number will link to the code, and I think we should always have a direct link to the latest code.

Do you agree?

@olizilla
Copy link
Member

olizilla commented Oct 2, 2018

that's reasonable. I can get behind being extra explicit here.

@fsdiogo
Copy link
Contributor

fsdiogo commented Oct 2, 2018

Cool, I'll open a PR.

What will be the plan to update the git revision?

Here it is: #844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Development

No branches or pull requests

3 participants