Twitter Cards #228
Merged
Twitter Cards #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding a new markdown dependency to our components means we end up shipping the whole library to the client, in most cases we'll never need to use this for dynamic rendering, so we can opt-in to the new (experimental) Overall this reduces the initial payload by ~500kb, which is a great win with little compromise. We can do a deeper optimization at a later stage too.
|
cwaring
approved these changes
May 10, 2023
cwaring
added a commit
that referenced
this pull request
May 10, 2023
* Add twitter card images * Add MarkdownContent component * Twitter cards and data * Change markdown file to yaml file * Convert html in _data to yaml * rm marked * use nuxt markdown lib (for now) * enable componentIslands * use component islands to render markdown on server * rebuild pnpm-lock * flatten props * use carbon twitter icon * squish imgs --------- Co-authored-by: cw <[email protected]>
cwaring
added a commit
that referenced
this pull request
Sep 5, 2023
* feat: Nuxt 3 app rebase (#203) * rm old framwork base files * sketch out nuxt 3 upgrade and disable old files * bump nuxt/content * add base tsconfig * nuxt 3.4.2 * feat: app base hero (#204) * rm old framwork base files * sketch out nuxt 3 upgrade and disable old files * bump nuxt/content * add base tsconfig * Setup IBM Plex font and remove others * Update README to reference pnpm * Remove old images * Hero and PageSection components * Add background color to PageSection and use in Hero * Add empty line at base of fonts.css * Remote template literal from section class attribute * nuxt 3.4.2 * Use Bunny CDN fonts * Add id attribute to page section * Add a max-width to content area in hero * use web font provider * Default hero to short variation but add prop to use a tall one for home page * rm v2 configs * Update pages/index.vue * compress assets --------- Co-authored-by: Chris Waring <[email protected]> * fix: rm old config * chore: update deps * feat: add community and developers pages (#206) * feat: home layout & related comps (#207) * Heading and Subhead components * PageSection responsive styling * ImageSplit component * Btn component * Home layout and refine some components * Home page components and resources * Remove unused hero component * update gitignore * Remove unused componemts * Add footer * Update uno colors and button styles * Update newsletter component * Update components on home page * Footer revisions and social links * More footer refinements * refactor: use switch * ignore .output * refactor: use object/array syntax for dyn class * Add card type 2 * Update script style of newsletter component * Add list links * Add footer constellations * Add excerpt attribute to card * Refactor image split component * Footer formatting updates * Update page section spacing * Use object syntax for dynamic class * Repair page section * Avoid undefined style in image split component * Medium grid columns * Grid shouldn't have those props * add isExternal fn to AppLink * fix: resolve merge conflict * fix: this should work once type imports are live --------- Co-authored-by: Chris Waring <[email protected]> * fix: switch ternary * fix: temp remove broken comps * fix: linting and disable failing routes * chore: set static only * feat: configure ci (#210) * setup docker image and build cmd * use node-18 * fix: case sensitive path * fix: rm missing css * fix: explicitly set .output/public * feat: enable SSG * feat: community and developer pages (#211) * Heading and Subhead components * PageSection responsive styling * ImageSplit component * Btn component * Home layout and refine some components * Home page components and resources * Remove unused hero component * update gitignore * Remove unused componemts * Add footer * Update uno colors and button styles * Update newsletter component * Update components on home page * Footer revisions and social links * More footer refinements * refactor: use switch * ignore .output * refactor: use object/array syntax for dyn class * Add card type 2 * Update script style of newsletter component * Add list links * Add footer constellations * Add excerpt attribute to card * Refactor image split component * Footer formatting updates * Update page section spacing * Use object syntax for dynamic class * Repair page section * Avoid undefined style in image split component * Medium grid columns * Grid shouldn't have those props * add isExternal fn to AppLink * fix: resolve merge conflict * Connect section * Community page wip * Developers page wip * add carbon icons * Spacing updates * Link updates --------- Co-authored-by: Chris Waring <[email protected]> * apply AppLink styles directly * style: enable font smoothing * feat: master header (#212) * add vueuse * add ipfs icon * sketch out header refactor * map out base styles * add eslint class sorting * add eslint plugin * sort class * use default export * add nav visibility state * refactor state * adjust classes * cleanup * class refactor * chore: upgrade deps * chore: lint and formatting (#220) * chore: apply review (#221) * apply review reqs * fix: trim link whitespace * Remove relative image paths * feat: responsive table component (#227) * feat: mobile nav (#229) * refactor social links * refactor mobileMenu * wire up menu and emits * rm icon.vue * feat: carousel cards (#230) * Carousel card component on index and developers pages * Finesse responsive styles * tweaks for responsive and CLS --------- Co-authored-by: Chris Waring <[email protected]> * chore: update deps * feat: twitter cards (#228) * Add twitter card images * Add MarkdownContent component * Twitter cards and data * Change markdown file to yaml file * Convert html in _data to yaml * rm marked * use nuxt markdown lib (for now) * enable componentIslands * use component islands to render markdown on server * rebuild pnpm-lock * flatten props * use carbon twitter icon * squish imgs --------- Co-authored-by: cw <[email protected]> * refactor: telescope for mobile (#236) Co-authored-by: cw <[email protected]> * chore: upgrade to nuxt 3.5 (#241) * update to v3.5 * remove extended types for now * feat: seo kit (#240) * add seo-kit * add config * setup base page config * tweak config * rm defaults * refactor static assets * setup simple meta titles * simplify and rm old meta tags * disable 404 fails * refactor: simplify tags * bump deps * feat: add motion (#243) * bump deps * update deps * add v-motion-fade-visible-once to page seciton * add index.css * chore: update deps * feat: add nuxt devtools * chore: bump deps * feat: ribbon component (#245) * Add ribbon component * Add ribbon images * Tighten ribbon component to bottom of section * Hide annotations on mobile * Fix overflow issues * Ribbon padding for home on mobile * refactor: formatting * compress assets --------- Co-authored-by: cw <[email protected]> * chore: nuxt v3.5.3 * fix: rm v-motion directive (for now) * chore: bump deps * feat: setup content pages (#252) * add ContentPage wrapper comp * create ContentPage stubs * add conditionals * add title case * chore: update deps * chore: update deps * chore: nuxt v3.6.1 * chore: update deps * fix: replace signup form with a button (#258) * feat: add testimonial carousel (#260) * Add testimonial carousel * refactor: mv heading and css tweaks * data and card pagination * add padding * cleanup --------- Co-authored-by: Chris Waring <[email protected]> * feat: connect blog data (#259) * sketch out media functionality * add types * add AppLink wrapper to card * remove placeholder images * chore: update/rebuild * add video cat * fixed aspect ratio * add blog placeholder (temp fix) * add blogUrl to config * fix: blogUrl * setup blogPlacehoder * typo * refactor: content review (#265) * typo * update peer text * build->develop * develop desc * getting started desc * dev link * rm page * rm img * change why ipfs * change open * typo * use ipfs apps * store desc * switch card order * participation copy * community cta * numbers title case * chore: update deps * rm dev mode * fix section padding * fix: contrib ctas * connect card content * social links and cal links * apply all wg card links * fix inline links * community desc * add cid docs * visual fixes * align subheads * add anytype link * update subtitle * update cards * update community cta * add browser card links * update ctas * rm duriniOS * rm browsers * add Durin apps * update links lists * use inline-block links (for now) * fix: lint * fix card layouts * font smoothing * simplify type styles * layout improvements * update data and assets * fix deep css * fix list style * fix deep css * pass custom btn labels * fix 3s logo * fix 3S logo * update snapshot url * mv antialiased to app css * add use case assets * fix 3s logo * header style cleanup * various cleanup * tweak spacing * fix layout spacing * fix: title spacing * chore: update deps * typo * refactor: rm global process * refactor: static routes * fix: wg spacing * chore: update deps (#269) * chore: update deps * refactor: default layout fix * refactor: content review p2 (#271) * update fingerprinting * update developers * review edits * fix spacing * lint --fix * update deps * add wg descriptions * mv titles * responsive tweaks * comp assets * fix inner card spacing * fix: update community subhead * fix: add period * chore: update deps * feat: migrate to vite build managed assets (#278) * add config notes * chore: update deps * mv assets * update deps * rm unused icons * update comp asset paths * fix: add webp and jpeg to useAsset * fix: swap out absolute img path for useAsset * fix: add sitemap excludes * mv to ipfs _redirects * fix: path redirects * chore: update nuxt v3.7.x + deps (#279) * chore: update deps * fix: rm log * update @nuxt/content * bump deps * fix: inline-block links * fix: use trailingSlash * fix: ignore link checker hash fails (for now) * rebuild pnpm-lock * chore: nuxt v3.7.1 update * fix: mv seoKit config * add simple global link hovers --------- Co-authored-by: Tom Benbow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya Chris, I think this is ready to merge but I'm not fetching the Twitter profile images from Twitter. I think we need an API key for that and I'm not sure if they are free anymore. I think we'll want to keep the images I have in here as fallbacks regardless. Maybe we can put that in another PR?
The cards aren't lining up nicely at the bottom like in the layout either. I notice that they have some extra space after posts to pull that off. Not sure how manageable that would be for editors, maybe it's worth it?
fixes: #198