Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text coding error in Chinese #1728

Closed
aihy opened this issue Jan 8, 2021 · 5 comments · Fixed by #1729
Closed

Text coding error in Chinese #1728

aihy opened this issue Jan 8, 2021 · 5 comments · Fixed by #1729
Assignees
@jessicaschilling
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws)

Comments

@aihy
Copy link

aihy commented Jan 8, 2021

Text coding error in Chinese

  1. Click on Download
    image
  2. See two buttons text error
    image

at macOS Big Sur 11.1
ipfs-desktop 0.13.2
@welcome

This comment has been minimized.

Sign in to view
@jessicaschilling
Copy link
Contributor

Thanks for finding this! Is it the only place in the app where you see an error like that?

@aihy
Copy link
Author

aihy commented Jan 8, 2021

Yes, it is the only place.

@jessicaschilling
Copy link
Contributor

Transferring to ipfs-desktop repo, as this is in one of Desktop's Electron menus.

@jessicaschilling jessicaschilling transferred this issue from ipfs/ipfs-webui Jan 8, 2021
@ipfs ipfs deleted a comment from welcome bot Jan 8, 2021
@jessicaschilling jessicaschilling mentioned this issue Jan 8, 2021
Merged
@jessicaschilling
Copy link
Contributor

#1729 should fix this.

@jessicaschilling jessicaschilling self-assigned this Jan 8, 2021
@jessicaschilling jessicaschilling added exp/novice Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours kind/bug A bug in existing code (including security flaws) labels Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessicaschilling jessicaschilling

Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explicitly specify content-type in prompt template ipfs/ipfs-desktop
2 participants
@jessicaschilling @aihy