Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving security of window.ipfs (low hanging fruits) #484

Merged
merged 2 commits into from
May 23, 2018
Merged

Improving security of window.ipfs (low hanging fruits) #484

merged 2 commits into from
May 23, 2018

Conversation

lidel
Copy link
Member

@lidel lidel commented May 23, 2018 •
edited
Loading

@olizilla please take a look, I want to merge this today 🐎

@lidel lidel added topic/security Work related to security area/window-ipfs Issues related to IPFS API exposed on every page labels May 23, 2018
@lidel lidel requested a review from olizilla May 23, 2018 17:19
lidel added 2 commits May 23, 2018 19:20
@lidel
fix: restrict window.ipfs to Secure Contexts
375f2c2
@lidel
fix: introduce global whitelist for window.ipfs
6c4c51f 
- ideally we want to move API whitelist to ipfs-postmsg-proxy
- closes #478
- mitigates #452
@lidel lidel force-pushed the feat/securing-window-ipfs branch from 199e1c5 to 6c4c51f Compare May 23, 2018 18:26
@lidel lidel merged commit 41e62df into master May 23, 2018
@lidel lidel deleted the feat/securing-window-ipfs branch May 23, 2018 18:31
@lidel lidel mentioned this pull request Jun 4, 2018
Closed
12 tasks
@lidel lidel mentioned this pull request Jul 3, 2018
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olizilla olizilla Awaiting requested review from olizilla

Assignees
No one assigned
Labels
area/window-ipfs Issues related to IPFS API exposed on every page topic/security Work related to security
Projects
None yet
Milestone
No milestone
1 participant
@lidel