feat(mv3): Adding ContextMenus MV3 Style #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whizzzkid
commented
May 31, 2023
| title: browser.i18n.getMessage(id), | ||
| contexts: [contextType], | ||
| documentUrlPatterns: ['<all_urls>'], | ||
| enabled: false |
There was a problem hiding this comment.
earlier we could just pass onClick which is no longer the case.
| @@ -3,6 +3,7 @@ | |||
| import browser from 'webextension-polyfill' | |||
|
|
|||
| import debug from 'debug' | |||
| import { ContextMenus } from './context-menus/ContextMenus.js' | |||
There was a problem hiding this comment.
the abstraction now exists as it's own class.
| * init is called once on extension startup | ||
| */ | ||
| init (): void { | ||
| browser.contextMenus.onClicked.addListener((info, tab) => { |
There was a problem hiding this comment.
the global listener.
| browser.contextMenus.onClicked.addListener((info, tab) => { | ||
| const { menuItemId } = info | ||
| if (this.contextMenuListeners.has(menuItemId)) { | ||
| this.contextMenuListeners.get(menuItemId)?.forEach(cb => cb(info, tab)) |
There was a problem hiding this comment.
we can have multiple listeners per item id.
| * @param options | ||
| * @param cb | ||
| */ | ||
| create (options: browser.Menus.CreateCreatePropertiesType, cb?: listenerCb): void { |
There was a problem hiding this comment.
just simplification of the queueListener method, which allows creating the menu item and register the listner.
There was a problem hiding this comment.
nit: CreateCreatePropertiesType name is odd
also, why cb as a second parameter instead of part of the create options?
SgtPooki
approved these changes
Jun 1, 2023
| contexts: [contextType], | ||
| documentUrlPatterns: [ | ||
| '*://*/ipfs/*', '*://*/ipns/*', | ||
| '*://*.ipfs.dweb.link/*', '*://*.ipns.dweb.link/*', // TODO: add any custom public gateway from Preferences |
There was a problem hiding this comment.
We should make an issue from this todo if we don't have one
| * @param options | ||
| * @param cb | ||
| */ | ||
| create (options: browser.Menus.CreateCreatePropertiesType, cb?: listenerCb): void { |
There was a problem hiding this comment.
nit: CreateCreatePropertiesType name is odd
also, why cb as a second parameter instead of part of the create options?
| try { | ||
| browser.contextMenus.create(options) | ||
| } catch (err) { | ||
| this.log.error?.('ContextMenus.create failed', err) |
There was a problem hiding this comment.
error is defined definitively in the constructor
Suggested change
| this.log.error?.('ContextMenus.create failed', err) | |
| this.log.error('ContextMenus.create failed', err) |
There was a problem hiding this comment.
tsc is not happy with this.
I agree, but |
whizzzkid
added a commit
that referenced
this pull request
Sep 15, 2023
* feat(mv3): Manifest V3 Migration Checklist (#1170) * feat(mv3): :sparkles: MV3 Manifest Migration * fix(mv3): :wastebasket: No longer needed * fix(mv3): :wrench: Corresponding MV3 Changes * feat(mv3): :package: Adding deps * feat(telemetry): Refactor Metrics Tracking from background service_worker (#1172) * feat(telemetry): :recycle: Init Telemetry away from background service_worker. * feat(telemetry): :recycle: Track metrics from page context instead of service_worker context * feat(mv3): :adhesive_bandage: Patch @protobufjs/inquire to not have eval * fix(mv3): :alien: Fixing contextMenus API changes (#1177) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): webpack configs (#1178) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): :wrench: Fixing webpack config * fix(mv3): :adhesive_bandage: Patching debug package and making background sw work. * feat(mv3): ✨ XHR to Fetch Migration (#1179) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): :wrench: Fixing webpack config * fix(mv3): :adhesive_bandage: Patching debug package and making background sw work. * feat(mv3): :sparkles: XMLHttpRequest => fetch * fix(mv3): :construction: Related changes to ipfs-path * fix(mv3): :construction: Other Related changes * fix(mv3): :construction: Changes to companion * fix(mv3): :white_check_mark: Fixing tests to account for async code. * Fix(mv3): Popup Was Broken (#1180) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): :wrench: Fixing webpack config * fix(mv3): :adhesive_bandage: Patching debug package and making background sw work. * feat(mv3): :sparkles: XMLHttpRequest => fetch * fix(mv3): :construction: Related changes to ipfs-path * fix(mv3): :construction: Other Related changes * fix(mv3): :construction: Changes to companion * fix(mv3): :white_check_mark: Fixing tests to account for async code. * feat(mv3): :recycle: Implementing a non-windowed companion instance * fix(mv3): :wastebasket: Removing calls to background page. * fix: :wastebasket: Unneeded debug statement * fix(mv3): :passport_control: Limiting permissions to chrome-extension * Update add-on/src/lib/ipfs-companion.js Co-authored-by: Russell Dempsey <[email protected]> --------- Co-authored-by: Russell Dempsey <[email protected]> * fix(mv3): CI Builds 🏗️ (#1183) * fix(mv3): :adhesive_bandage: package.json * fix(mv3): :rotating_light: Fix Lint * fix(mv3): :green_heart: Manifest version * feat: :adhesive_bandage: temporary building from rc-branch * feat(mv3): blocking by observing (#1181) * feat(mv3): :sparkles: MV3 Manifest Migration * fix(mv3): :wastebasket: No longer needed * fix(mv3): :wrench: Corresponding MV3 Changes * feat(mv3): :package: Adding deps * feat(telemetry): Refactor Metrics Tracking from background service_worker (#1172) * feat(telemetry): :recycle: Init Telemetry away from background service_worker. * feat(telemetry): :recycle: Track metrics from page context instead of service_worker context * feat(mv3): :adhesive_bandage: Patch @protobufjs/inquire to not have eval * fix(mv3): :alien: Fixing contextMenus API changes (#1177) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): webpack configs (#1178) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): :wrench: Fixing webpack config * fix(mv3): :adhesive_bandage: Patching debug package and making background sw work. * feat(mv3): ✨ XHR to Fetch Migration (#1179) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): :wrench: Fixing webpack config * fix(mv3): :adhesive_bandage: Patching debug package and making background sw work. * feat(mv3): :sparkles: XMLHttpRequest => fetch * fix(mv3): :construction: Related changes to ipfs-path * fix(mv3): :construction: Other Related changes * fix(mv3): :construction: Changes to companion * fix(mv3): :white_check_mark: Fixing tests to account for async code. * Fix(mv3): Popup Was Broken (#1180) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): :wrench: Fixing webpack config * fix(mv3): :adhesive_bandage: Patching debug package and making background sw work. * feat(mv3): :sparkles: XMLHttpRequest => fetch * fix(mv3): :construction: Related changes to ipfs-path * fix(mv3): :construction: Other Related changes * fix(mv3): :construction: Changes to companion * fix(mv3): :white_check_mark: Fixing tests to account for async code. * feat(mv3): :recycle: Implementing a non-windowed companion instance * fix(mv3): :wastebasket: Removing calls to background page. * fix: :wastebasket: Unneeded debug statement * fix(mv3): :passport_control: Limiting permissions to chrome-extension * Update add-on/src/lib/ipfs-companion.js Co-authored-by: Russell Dempsey <[email protected]> * fix(types): :label: Refactoring existing type declaration * fix(types): :label: Moving to new types path * feat(types): :sparkles: Adding typescript support for transpilation * feat(mv3): :sparkles: Adding blocking request tester * fix(mv3): :adhesive_bandage: package.json * fix(mv3): :rotating_light: Fix Lint * fix: :rotating_light: fix lint * fix(mv3): :adhesive_bandage: temp fix to build background context * fix(mv3): :necktie: Detection Logic for MV3 world. * feat(mv3): :sparkles: Dynamic RegexSubstitution * fix(types): :arrow_up: Adding .mocharc.json to fix mocha for TS. * fix: :rotating_light: Lint Fix * fix(mv3): :recycle: refactor background.service_worker * feat(mv3): :sparkles: Passing state to BlockOrObserve * fix(recovery): :bug: conditional for recovery * fix: :wastebasket: unneeded @ts-ignore * fix: :bulb: Adding comments * fix: fixing string method. * fix: removing extra space. * fix: removing @ts-nocheck --------- Co-authored-by: Russell Dempsey <[email protected]> * feat(mv3): adding dynamicNetRequest rule reconciliation logic + Firefox Builds (#1186) * feat(mv3): :sparkles: MV3 Manifest Migration * fix(mv3): :wastebasket: No longer needed * fix(mv3): :wrench: Corresponding MV3 Changes * feat(mv3): :package: Adding deps * feat(telemetry): Refactor Metrics Tracking from background service_worker (#1172) * feat(telemetry): :recycle: Init Telemetry away from background service_worker. * feat(telemetry): :recycle: Track metrics from page context instead of service_worker context * feat(mv3): :adhesive_bandage: Patch @protobufjs/inquire to not have eval * fix(mv3): :alien: Fixing contextMenus API changes (#1177) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): webpack configs (#1178) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): :wrench: Fixing webpack config * fix(mv3): :adhesive_bandage: Patching debug package and making background sw work. * feat(mv3): ✨ XHR to Fetch Migration (#1179) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): :wrench: Fixing webpack config * fix(mv3): :adhesive_bandage: Patching debug package and making background sw work. * feat(mv3): :sparkles: XMLHttpRequest => fetch * fix(mv3): :construction: Related changes to ipfs-path * fix(mv3): :construction: Other Related changes * fix(mv3): :construction: Changes to companion * fix(mv3): :white_check_mark: Fixing tests to account for async code. * Fix(mv3): Popup Was Broken (#1180) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): :wrench: Fixing webpack config * fix(mv3): :adhesive_bandage: Patching debug package and making background sw work. * feat(mv3): :sparkles: XMLHttpRequest => fetch * fix(mv3): :construction: Related changes to ipfs-path * fix(mv3): :construction: Other Related changes * fix(mv3): :construction: Changes to companion * fix(mv3): :white_check_mark: Fixing tests to account for async code. * feat(mv3): :recycle: Implementing a non-windowed companion instance * fix(mv3): :wastebasket: Removing calls to background page. * fix: :wastebasket: Unneeded debug statement * fix(mv3): :passport_control: Limiting permissions to chrome-extension * Update add-on/src/lib/ipfs-companion.js Co-authored-by: Russell Dempsey <[email protected]> * fix(types): :label: Refactoring existing type declaration * fix(types): :label: Moving to new types path * feat(types): :sparkles: Adding typescript support for transpilation * feat(mv3): :sparkles: Adding blocking request tester * fix(mv3): :adhesive_bandage: package.json * fix(mv3): :rotating_light: Fix Lint * fix: :rotating_light: fix lint * fix(mv3): :adhesive_bandage: temp fix to build background context * fix(mv3): :necktie: Detection Logic for MV3 world. * feat(mv3): :sparkles: Dynamic RegexSubstitution * fix(types): :arrow_up: Adding .mocharc.json to fix mocha for TS. * fix: :rotating_light: Lint Fix * fix(mv3): :recycle: refactor background.service_worker * feat(mv3): :sparkles: Passing state to BlockOrObserve * fix(recovery): :bug: conditional for recovery * fix: :wastebasket: unneeded @ts-ignore * fix: :bulb: Adding comments * fix: fixing string method. * fix: removing extra space. * fix: removing @ts-nocheck * no longer needed * fix(mv3): :recycle: Refactor * feat(mv3): :sparkles: Adding rule-recon logic * saving state * fix(mv3): :wrench: Manifest * fix(mv3): :wrench: Fixing firefox webpack config * fix(mv3): :adhesive_bandage: Patching debug to use in memory store instead of browser.storage.local * fix: :rotating_light: fixing lint and moving from record type to map type. * fix: :memo: Adding docstrings. * fix(mv3): :poop: web-ext making things harder than it needs to be. * fix(mv3): :rewind: no more debug patching * fix(mv3): :poop: improved recon logic * fix: :memo: adding comments regarding debug. * fix: :rotating_light: Fix lint * fix(mv3): :passport_control: manifest perms * fix: :wastebasket: unnecessary blank line * feat(mv3): :test_tube: Adding initial tests * feat(mv3): :clown_face: Adding Mock DeclarativeNetRequest Implementation * nits * fix: adding more test examples * fix: self-documenting code. * fix: unneeded comment * Update test/functional/lib/redirect-handler/blockOrObserve.test.ts --------- Co-authored-by: Russell Dempsey <[email protected]> * Chore(mv3-release): Publishing RC releases (#1192) * feat(mv3): :sparkles: MV3 Manifest Migration * fix(mv3): :wastebasket: No longer needed * fix(mv3): :wrench: Corresponding MV3 Changes * feat(mv3): :package: Adding deps * feat(telemetry): Refactor Metrics Tracking from background service_worker (#1172) * feat(telemetry): :recycle: Init Telemetry away from background service_worker. * feat(telemetry): :recycle: Track metrics from page context instead of service_worker context * feat(mv3): :adhesive_bandage: Patch @protobufjs/inquire to not have eval * fix(mv3): :alien: Fixing contextMenus API changes (#1177) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): webpack configs (#1178) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): :wrench: Fixing webpack config * fix(mv3): :adhesive_bandage: Patching debug package and making background sw work. * feat(mv3): ✨ XHR to Fetch Migration (#1179) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): :wrench: Fixing webpack config * fix(mv3): :adhesive_bandage: Patching debug package and making background sw work. * feat(mv3): :sparkles: XMLHttpRequest => fetch * fix(mv3): :construction: Related changes to ipfs-path * fix(mv3): :construction: Other Related changes * fix(mv3): :construction: Changes to companion * fix(mv3): :white_check_mark: Fixing tests to account for async code. * Fix(mv3): Popup Was Broken (#1180) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): :wrench: Fixing webpack config * fix(mv3): :adhesive_bandage: Patching debug package and making background sw work. * feat(mv3): :sparkles: XMLHttpRequest => fetch * fix(mv3): :construction: Related changes to ipfs-path * fix(mv3): :construction: Other Related changes * fix(mv3): :construction: Changes to companion * fix(mv3): :white_check_mark: Fixing tests to account for async code. * feat(mv3): :recycle: Implementing a non-windowed companion instance * fix(mv3): :wastebasket: Removing calls to background page. * fix: :wastebasket: Unneeded debug statement * fix(mv3): :passport_control: Limiting permissions to chrome-extension * Update add-on/src/lib/ipfs-companion.js Co-authored-by: Russell Dempsey <[email protected]> * fix(types): :label: Refactoring existing type declaration * fix(types): :label: Moving to new types path * feat(types): :sparkles: Adding typescript support for transpilation * feat(mv3): :sparkles: Adding blocking request tester * fix(mv3): :adhesive_bandage: package.json * fix(mv3): :rotating_light: Fix Lint * fix: :rotating_light: fix lint * fix(mv3): :adhesive_bandage: temp fix to build background context * fix(mv3): :necktie: Detection Logic for MV3 world. * feat(mv3): :sparkles: Dynamic RegexSubstitution * fix(types): :arrow_up: Adding .mocharc.json to fix mocha for TS. * fix: :rotating_light: Lint Fix * fix(mv3): :recycle: refactor background.service_worker * feat(mv3): :sparkles: Passing state to BlockOrObserve * fix(recovery): :bug: conditional for recovery * fix: :wastebasket: unneeded @ts-ignore * fix: :bulb: Adding comments * fix: fixing string method. * fix: removing extra space. * fix: removing @ts-nocheck * no longer needed * fix(mv3): :recycle: Refactor * feat(mv3): :sparkles: Adding rule-recon logic * saving state * fix(mv3): :wrench: Manifest * fix(mv3): :wrench: Fixing firefox webpack config * fix(mv3): :adhesive_bandage: Patching debug to use in memory store instead of browser.storage.local * fix: :rotating_light: fixing lint and moving from record type to map type. * fix: :memo: Adding docstrings. * fix(mv3): :poop: web-ext making things harder than it needs to be. * fix(mv3): :rewind: no more debug patching * fix(mv3): :poop: improved recon logic * fix: :memo: adding comments regarding debug. * fix: :rotating_light: Fix lint * fix(mv3): :passport_control: manifest perms * fix: :wastebasket: unnecessary blank line * feat(mv3): :test_tube: Adding initial tests * feat(mv3): :clown_face: Adding Mock DeclarativeNetRequest Implementation * nits * fix: adding more test examples * fix: self-documenting code. * fix: unneeded comment * Creating RC Releases --------- Co-authored-by: Russell Dempsey <[email protected]> * fix(mv3): ref_name (#1193) * Fix/mv3 release (#1194) * fix(mv3): ref_name * fix: this is hard to test * Fixing beta builds * fix(mv3): :bug: Bad Regex for DNS links (#1198) * fix(mv3): :bug: Fixing copy functionality for MV3 (#1197) * fix(mv3): :bug: Fixing copy functionality for MV3 * fix: * Update add-on/src/lib/copier.js * feat(mv3): Handle State Changes (#1200) * fix(mv3): Add support for global toggle on/off * feat(mv3): Handle State Changes * fix(mv3): :recycle: Refactoring code to only message self in observation mode. * Fix/1202 first page is missing content (#1208) * fix: :arrow_up: package-lock * feat(mv3): :recycle: Reload tabs with request url. * fix(mv3): 👔 Adding better regex replace to remove infinite redirects. (#1210) * fix(mv3): :necktie: Adding better regex replace to remove infinite redirects. * fix(mv3): :test_tube: Adding more tests to account for local redirects * fix: :rotating_light: Linter * feat(mv3): :clown_face: DeclarativeNetRequestMock (#1211) * fix(mv3): :necktie: Adding better regex replace to remove infinite redirects. * fix(mv3): :test_tube: Adding more tests to account for local redirects * feat(mv3): :clown_face: DeclarativeNetRequestMock * fix: :rotating_light: Linter * feat(mv3): Adding ContextMenus MV3 Style (#1213) * feat(mv3): :sparkles: ContextMenus MV3 Style * feat(mv3): :test_tube: Adding tests * fix: test case * fix (quick-import): Duplicate behaviour in MV3 (#1215) * feat(mv3): :sparkles: ContextMenus MV3 Style * feat(mv3): :test_tube: Adding tests * fix: test case * fix(mv3): :bug: Quick Import * fix(mv3): :wastebasket: Removing Unnecessary Listener (#1219) * fix: Automatic Mode Description (#1224) * fix: :adhesive_bandage: Adding Automatic Mode Description * Update add-on/_locales/en/messages.json Co-authored-by: Steve Loeppky <[email protected]> * Update add-on/_locales/en/messages.json Co-authored-by: Steve Loeppky <[email protected]> --------- Co-authored-by: Steve Loeppky <[email protected]> * fix: 🗑️ Remove Embedded Node Type (#1225) * fix: :wastebasket: no longer needed Signed-off-by: Nishant Arora <[email protected]> * fix: :wastebasket: unneeded messages Signed-off-by: Nishant Arora <[email protected]> * fix: :wastebasket: Removing unneeded test Signed-off-by: Nishant Arora <[email protected]> * fix: :necktie: Update logic or add todos to fix this later. Signed-off-by: Nishant Arora <[email protected]> * fix: :wastebasket: remove logos Signed-off-by: Nishant Arora <[email protected]> * fix: lint warning Signed-off-by: Nishant Arora <[email protected]> * fix: :alien: no idea why this is a problem now. Signed-off-by: Nishant Arora <[email protected]> * fix: :wastebasket: irrelevant Signed-off-by: Nishant Arora <[email protected]> * fix: quick-import Signed-off-by: Nishant Arora <[email protected]> * fix: Fixing quick-import Signed-off-by: Nishant Arora <[email protected]> * fix: Fixing Tools Signed-off-by: Nishant Arora <[email protected]> * fix: fixing gateway-form Signed-off-by: Nishant Arora <[email protected]> * fix: content-action Signed-off-by: Nishant Arora <[email protected]> * fix: store Signed-off-by: Nishant Arora <[email protected]> * fix: Fixing state Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> * Fix(docs): ✏️ Adding/Updating docs (#1230) * fix(docs): :pencil2: Api -> kubo rpc api Signed-off-by: Nishant Arora <[email protected]> * fix(docs): :pencil2: reword Signed-off-by: Nishant Arora <[email protected]> * fix(docs): :heavy_plus_sign: Adding MV3 Migration Docs and Assets. Signed-off-by: Nishant Arora <[email protected]> * Update docs/MV3.md Co-authored-by: Russell Dempsey <[email protected]> * Update docs/MV3.md Co-authored-by: Russell Dempsey <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> Co-authored-by: Russell Dempsey <[email protected]> * feat(metrics): ✨ Adding patched analytics. (#1232) * feat(mv3): :sparkles: Patching countly-sdk-web Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): :sparkles: Implementing Custom Async Store. Signed-off-by: Nishant Arora <[email protected]> * chore(mv3): :adhesive_bandage: Hooking everything up together. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): Countly Patching + [email protected] Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :adhesive_bandage: Patching the Patch Signed-off-by: Nishant Arora <[email protected]> * fix: tests Signed-off-by: Nishant Arora <[email protected]> * fix: lint Signed-off-by: Nishant Arora <[email protected]> * fix: :adhesive_bandage: Patching error messages Signed-off-by: Nishant Arora <[email protected]> * fix(patch): countly-web-sdk * fix(patch): :pin: Pinning countly-web-sdk to 23.2.2 --------- Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :art: Replacing Static Images with Mermaid Diagrams (#1233) * fic(mv3): :art: Replacing Static Images with Mermaid Diagrams * fix(mv3): :pencil2: Improving Grammar Signed-off-by: Nishant Arora <[email protected]> * Adding Colors Co-authored-by: Russell Dempsey <[email protected]> * Update docs/MV3.md --------- Signed-off-by: Nishant Arora <[email protected]> Co-authored-by: Russell Dempsey <[email protected]> * feat(mv3): Faster Redirects During The First Page Load in main_frame (#1239) * feat(mv3): :zap: Faster redirects for the first time. Signed-off-by: Nishant Arora <[email protected]> * fix: removing only from the tests Signed-off-by: Nishant Arora <[email protected]> * test(mv3): Adding removing rule example. Signed-off-by: Nishant Arora <[email protected]> * test(mv3): :test_tube: Added test regarding removal of rules Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> * fix(telemetry): Reverting to old state of things (#1242) * fix(mv3): Reverting Telemetry Changes To Use PatchedCountlySDK Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): metrics build Signed-off-by: Nishant Arora <[email protected]> * fix: more reverts + fixing patch Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :adhesive_bandage: Patching the Patch Signed-off-by: Nishant Arora <[email protected]> * fix(countly): :adhesive_bandage: don't look for debug, just log it. Signed-off-by: Nishant Arora <[email protected]> * fix(countly): removing session start/end. Signed-off-by: Nishant Arora <[email protected]> * fix: unused var Signed-off-by: Nishant Arora <[email protected]> * fix(countly): patch * revert * fix(countly): repatch, old one seems to be failing. * fix(countly): bad patch * revert * retrying patch * fix: patch files should not be cached. Signed-off-by: Nishant Arora <[email protected]> * fix: fixing cache keys Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): ✨ Introduces Redirect Rule Management (#1240) * feat: exporting rules ending regex Signed-off-by: Nishant Arora <[email protected]> * feat: :sparkles: Adding Rule Management UI Signed-off-by: Nishant Arora <[email protected]> * feat: :sparkles: hooking up with background worker. Signed-off-by: Nishant Arora <[email protected]> * fix: lint Signed-off-by: Nishant Arora <[email protected]> * fix: :art: button styling Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :lipstick: Making UI a bit better Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): Tracking URL resolved/observed count. (#1245) * fix(mv3): Reverting Telemetry Changes To Use PatchedCountlySDK Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): metrics build Signed-off-by: Nishant Arora <[email protected]> * fix: more reverts + fixing patch Signed-off-by: Nishant Arora <[email protected]> * feat: adding request view. Signed-off-by: Nishant Arora <[email protected]> * Reverting to mainline rc patch * Reverting to mainline rc add-on/src/lib/ipfs-companion.js * feat(telemetry): Signed-off-by: Nishant Arora <[email protected]> * feat(telemetry): Implementing RequestTracker Event Handler Signed-off-by: Nishant Arora <[email protected]> * feat(telemetry): hooking up events. Signed-off-by: Nishant Arora <[email protected]> * fix(types): annotations * fix(telemetry): :wastebasket: returning to previous state Signed-off-by: Nishant Arora <[email protected]> * fix(telemetry): :recycle: Refactor Request Tracker Signed-off-by: Nishant Arora <[email protected]> * fix(telemetry): hooking up requests Signed-off-by: Nishant Arora <[email protected]> * fix(telemetry): better types Signed-off-by: Nishant Arora <[email protected]> * fix(countly): :wastebasket: more stuff goes, because test need to pass. Signed-off-by: Nishant Arora <[email protected]> * fix(lint): fixed * feat(test): test tracker. * fix: remove only Signed-off-by: Nishant Arora <[email protected]> * fix: :lipstick: line break Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): Ask for Host Permissions if not exist. (#1250) * feat(mv3): :sparkles: Requesting Host Permissions Explicitly Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): :bug: Adding perms step on installed. Signed-off-by: Nishant Arora <[email protected]> * fix: request-permission-view tracking Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): Making permissions agnostic to browser Signed-off-by: Nishant Arora <[email protected]> * docs: clarify why we need host permission making prompt less scary, shorter, and informative * Update add-on/src/lib/ipfs-request.js Co-authored-by: Marcin Rataj <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> Co-authored-by: Marcin Rataj <[email protected]> * feat(mv3): Redirection Tests (#1236) * feat(mv3): :sparkles: Patching countly-sdk-web Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): :sparkles: Implementing Custom Async Store. Signed-off-by: Nishant Arora <[email protected]> * chore(mv3): :adhesive_bandage: Hooking everything up together. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): Countly Patching + [email protected] Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :adhesive_bandage: Patching the Patch Signed-off-by: Nishant Arora <[email protected]> * fix: tests Signed-off-by: Nishant Arora <[email protected]> * fix: lint Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :recycle: Refactoring `supportsBlock` Checks. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): Regex Bug Signed-off-by: Nishant Arora <[email protected]> * feat: Migrating blocking redirection test to observing redirection test Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :wrench: Fixing the mocha-setup. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :recycle: Moving Setup Files. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): gateway-redirect tests now fixed. Signed-off-by: Nishant Arora <[email protected]> * fix: :adhesive_bandage: Patching error messages Signed-off-by: Nishant Arora <[email protected]> * fix(patch): countly-web-sdk * fix(patch): :pin: Pinning countly-web-sdk to 23.2.2 * fix(mv3): :lipstick: Fixing Lint Signed-off-by: Nishant Arora <[email protected]> * feat: protocol-handler-redirection-tests Signed-off-by: Nishant Arora <[email protected]> * feat: more tests fixed Signed-off-by: Nishant Arora <[email protected]> * fix: More tests Signed-off-by: Nishant Arora <[email protected]> * fix: lint fix Signed-off-by: Nishant Arora <[email protected]> * test: merge mocha-setup files (#1246) * test: merge mocha-setup files * test(helper): add mv3-test-enabled helper * test(setup): remove duplicate setup for mv3/mv2 * test(mv3): merge mv3 tests into mv2 test files (#1247) * test(mv3): merge mv3 tests into mv2 test files * chore(lint): fix lint failures * test(supportsBlock): cleanup test * test: migrating some tests * test(redirect): mv3 tests use same code as mv2 * test(redirect): mv3 test cleanup * test(protohandler): mv3 tests use same code as mv2 * test(helper): make isMv3 flag a boolean * test: fix after merge * test: fix after merge * fix: typerrors for localstorage Signed-off-by: Nishant Arora <[email protected]> * fix: Updating test:functional_MV3 command. Signed-off-by: Nishant Arora <[email protected]> * fix: setup Signed-off-by: Nishant Arora <[email protected]> * fix(test): Fixing tests Signed-off-by: Nishant Arora <[email protected]> * fix(lint): Becuase Ofcourse * feat(test): scaffolding mv3 + mv2 calls in a single check. Signed-off-by: Nishant Arora <[email protected]> * feat(test): unskipping and upgrading dnslink tests to mv3 Signed-off-by: Nishant Arora <[email protected]> * feat(test): Upgrading workaround tests to MV3 Signed-off-by: Nishant Arora <[email protected]> * fix(test): removing all skips with better checks. Signed-off-by: Nishant Arora <[email protected]> * fix(test): :recycle: Refactoring tests and removing redundant calls. Signed-off-by: Nishant Arora <[email protected]> * fix(test): More Dryer Signed-off-by: Nishant Arora <[email protected]> * fix(test): one more Signed-off-by: Nishant Arora <[email protected]> * fix(test): :pencil2: Renaming isMv3TestingEnabled -> isManifestV3 Signed-off-by: Nishant Arora <[email protected]> * fix(test): refactor expectNoRedirect Signed-off-by: Nishant Arora <[email protected]> * fix(test): :recycle: Refactoring more. Signed-off-by: Nishant Arora <[email protected]> * fix: replacing checks to undefined Signed-off-by: Nishant Arora <[email protected]> * fix: renaming expectNoRedirect -> ensureNoRedirect Signed-off-by: Nishant Arora <[email protected]> * fix(test): Adding missing JSDoc Signed-off-by: Nishant Arora <[email protected]> * fix(test): :shrug: how did this get removed. Signed-off-by: Nishant Arora <[email protected]> * fix(test): :wastebasket: removed. Signed-off-by: Nishant Arora <[email protected]> * fix(test): Suggestion * fix(test): :adhesive_bandage: Bad Merge Signed-off-by: Nishant Arora <[email protected]> * fix(test): sequential expectNoRedirect * Update add-on/src/lib/redirect-handler/blockOrObserve.ts Co-authored-by: Marcin Rataj <[email protected]> * fix(rules): Better Redirect Rules (#1256) * fix(mv3): :wrench: Modifying the default local redirect behaviour. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :wrench: Modifying the default local redirect behaviour. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :bug: Making rules less greedy Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :sparkles: Dynamic Rules for subdomain gateways. Signed-off-by: Nishant Arora <[email protected]> * fix(types): Adding ambient types for is-ipfs. Signed-off-by: Nishant Arora <[email protected]> * fix(test): Signed-off-by: Nishant Arora <[email protected]> * fix(test): helper Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): less greedy rules Signed-off-by: Nishant Arora <[email protected]> * feat: Adding simpler regex for redirects from similar namespaces. Signed-off-by: Nishant Arora <[email protected]> * fix(lint): :rotating_light: Warnings Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): Better Default Rules (#1260) * refactor(mv3): blockOrRequest code Signed-off-by: Nishant Arora <[email protected]> * refactor(mv3): Port Logic for Default Rules is more robust. Signed-off-by: Nishant Arora <[email protected]> * feat(test): Adding tests for default rule logic. Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> * Update add-on/src/lib/redirect-handler/blockOrObserve.ts * fix(docs): :pencil2: Adding comments Signed-off-by: Nishant Arora <[email protected]> * refactor(regexfilters): Better Structure and Readability (#1261) * refactor(regexFilters): :sparkles: Adding a base class for regexFilters. Signed-off-by: Nishant Arora <[email protected]> * refactor(regexFilters): :recycle: Moving subdomain filter to a subclass Signed-off-by: Nishant Arora <[email protected]> * refactor(regexFilters): :recycle: Moving namespace filter to a subclass Signed-off-by: Nishant Arora <[email protected]> * refactor(regexFilters): :recycle: Moving common filter to a subclass Signed-off-by: Nishant Arora <[email protected]> * feat(regexFilters): :sparkles: Hooking Up All together Signed-off-by: Nishant Arora <[email protected]> * fix(lint): :pencil2: Lint Signed-off-by: Nishant Arora <[email protected]> * fix(regexFilters): :pencil2: Updating message. Signed-off-by: Nishant Arora <[email protected]> * fix(rename): :pencil2: CommonPatterRedirectRegexFilter -> CommonPatternRedirectRegexFilter Signed-off-by: Nishant Arora <[email protected]> * fix(regexFilters): :recycle: Refactor to remove call to super Signed-off-by: Nishant Arora <[email protected]> * fix: make _canHandle private Signed-off-by: Nishant Arora <[email protected]> * fix: :zap: Fix math.min on every loop. Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): no blanket redirect for subdomains without namespaces. Signed-off-by: Nishant Arora <[email protected]> * fix(lint): unused import Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> Co-authored-by: Russell Dempsey <[email protected]> Co-authored-by: Marcin Rataj <[email protected]> * fix(recovery): Recovery Rules should reset (#1266) * feat(mv3): :sparkles: Patching countly-sdk-web Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): :sparkles: Implementing Custom Async Store. Signed-off-by: Nishant Arora <[email protected]> * chore(mv3): :adhesive_bandage: Hooking everything up together. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): Countly Patching + [email protected] Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :adhesive_bandage: Patching the Patch Signed-off-by: Nishant Arora <[email protected]> * fix: tests Signed-off-by: Nishant Arora <[email protected]> * fix: lint Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :recycle: Refactoring `supportsBlock` Checks. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): Regex Bug Signed-off-by: Nishant Arora <[email protected]> * feat: Migrating blocking redirection test to observing redirection test Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :wrench: Fixing the mocha-setup. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :recycle: Moving Setup Files. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): gateway-redirect tests now fixed. Signed-off-by: Nishant Arora <[email protected]> * fix: :adhesive_bandage: Patching error messages Signed-off-by: Nishant Arora <[email protected]> * fix(patch): countly-web-sdk * fix(patch): :pin: Pinning countly-web-sdk to 23.2.2 * fix(mv3): :lipstick: Fixing Lint Signed-off-by: Nishant Arora <[email protected]> * feat: protocol-handler-redirection-tests Signed-off-by: Nishant Arora <[email protected]> * feat: more tests fixed Signed-off-by: Nishant Arora <[email protected]> * fix: More tests Signed-off-by: Nishant Arora <[email protected]> * fix: lint fix Signed-off-by: Nishant Arora <[email protected]> * test: merge mocha-setup files (#1246) * test: merge mocha-setup files * test(helper): add mv3-test-enabled helper * test(setup): remove duplicate setup for mv3/mv2 * test(mv3): merge mv3 tests into mv2 test files (#1247) * test(mv3): merge mv3 tests into mv2 test files * chore(lint): fix lint failures * test(supportsBlock): cleanup test * test: migrating some tests * test(redirect): mv3 tests use same code as mv2 * test(redirect): mv3 test cleanup * test(protohandler): mv3 tests use same code as mv2 * test(helper): make isMv3 flag a boolean * test: fix after merge * test: fix after merge * fix: typerrors for localstorage Signed-off-by: Nishant Arora <[email protected]> * fix: Updating test:functional_MV3 command. Signed-off-by: Nishant Arora <[email protected]> * fix: setup Signed-off-by: Nishant Arora <[email protected]> * fix(test): Fixing tests Signed-off-by: Nishant Arora <[email protected]> * fix(lint): Becuase Ofcourse * feat(test): scaffolding mv3 + mv2 calls in a single check. Signed-off-by: Nishant Arora <[email protected]> * feat(test): unskipping and upgrading dnslink tests to mv3 Signed-off-by: Nishant Arora <[email protected]> * feat(test): Upgrading workaround tests to MV3 Signed-off-by: Nishant Arora <[email protected]> * fix(test): removing all skips with better checks. Signed-off-by: Nishant Arora <[email protected]> * fix(test): :recycle: Refactoring tests and removing redundant calls. Signed-off-by: Nishant Arora <[email protected]> * fix(test): More Dryer Signed-off-by: Nishant Arora <[email protected]> * fix(test): one more Signed-off-by: Nishant Arora <[email protected]> * fix(test): :pencil2: Renaming isMv3TestingEnabled -> isManifestV3 Signed-off-by: Nishant Arora <[email protected]> * fix(test): refactor expectNoRedirect Signed-off-by: Nishant Arora <[email protected]> * fix(test): :recycle: Refactoring more. Signed-off-by: Nishant Arora <[email protected]> * fix: replacing checks to undefined Signed-off-by: Nishant Arora <[email protected]> * fix: renaming expectNoRedirect -> ensureNoRedirect Signed-off-by: Nishant Arora <[email protected]> * fix(test): Adding missing JSDoc Signed-off-by: Nishant Arora <[email protected]> * fix(test): :shrug: how did this get removed. Signed-off-by: Nishant Arora <[email protected]> * fix(test): :wastebasket: removed. Signed-off-by: Nishant Arora <[email protected]> * fix(test): Suggestion * fix(test): :adhesive_bandage: Bad Merge Signed-off-by: Nishant Arora <[email protected]> * fix(test): sequential expectNoRedirect * Update add-on/src/lib/redirect-handler/blockOrObserve.ts Co-authored-by: Marcin Rataj <[email protected]> * fix(mv3): :wrench: Modifying the default local redirect behaviour. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :wrench: Modifying the default local redirect behaviour. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :bug: Making rules less greedy Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :sparkles: Dynamic Rules for subdomain gateways. Signed-off-by: Nishant Arora <[email protected]> * fix(types): Adding ambient types for is-ipfs. Signed-off-by: Nishant Arora <[email protected]> * fix(test): Signed-off-by: Nishant Arora <[email protected]> * fix(test): helper Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): less greedy rules Signed-off-by: Nishant Arora <[email protected]> * feat: Adding simpler regex for redirects from similar namespaces. Signed-off-by: Nishant Arora <[email protected]> * fix(lint): :rotating_light: Warnings Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): Better Default Rules (#1260) * refactor(mv3): blockOrRequest code Signed-off-by: Nishant Arora <[email protected]> * refactor(mv3): Port Logic for Default Rules is more robust. Signed-off-by: Nishant Arora <[email protected]> * feat(test): Adding tests for default rule logic. Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> * Update add-on/src/lib/redirect-handler/blockOrObserve.ts * fix(docs): :pencil2: Adding comments Signed-off-by: Nishant Arora <[email protected]> * refactor(regexFilters): :sparkles: Adding a base class for regexFilters. Signed-off-by: Nishant Arora <[email protected]> * refactor(regexFilters): :recycle: Moving subdomain filter to a subclass Signed-off-by: Nishant Arora <[email protected]> * refactor(regexFilters): :recycle: Moving namespace filter to a subclass Signed-off-by: Nishant Arora <[email protected]> * refactor(regexFilters): :recycle: Moving common filter to a subclass Signed-off-by: Nishant Arora <[email protected]> * feat(regexFilters): :sparkles: Hooking Up All together Signed-off-by: Nishant Arora <[email protected]> * fix(lint): :pencil2: Lint Signed-off-by: Nishant Arora <[email protected]> * fix(regexFilters): :pencil2: Updating message. Signed-off-by: Nishant Arora <[email protected]> * fix(rename): :pencil2: CommonPatterRedirectRegexFilter -> CommonPatternRedirectRegexFilter Signed-off-by: Nishant Arora <[email protected]> * fix(regexFilters): :recycle: Refactor to remove call to super Signed-off-by: Nishant Arora <[email protected]> * fix: make _canHandle private Signed-off-by: Nishant Arora <[email protected]> * fix: :zap: Fix math.min on every loop. Signed-off-by: Nishant Arora <[email protected]> * fix(recovery): reset rules Signed-off-by: Nishant Arora <[email protected]> * fix(recovery): :recycle: Refactor messaging logic Signed-off-by: Nishant Arora <[email protected]> * fix(recovery): :bug: Cleanup Logic Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :bug: fix toggle site integration. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :adhesive_bandage: Hard coding wait as the browser is not cooperative. Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> Co-authored-by: Russell Dempsey <[email protected]> Co-authored-by: Marcin Rataj <[email protected]> * fix(mv3): :bug: rules section visible. (#1271) Signed-off-by: Nishant Arora <[email protected]> * fix(brave): Fix Brave UX (#1270) * fix(options): fixing options menu Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): Adding brave specific redirects. Signed-off-by: Nishant Arora <[email protected]> * fix: lint Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> * feat(e2e): Request Handling Tests (#1272) * fix(test): :recycle: simplify scaffolding Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): :test_tube: Adding a final resolution check Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> * Update add-on/_locales/en/messages.json Co-authored-by: Marcin Rataj <[email protected]> * Update add-on/src/options/forms/api-form.js Co-authored-by: Marcin Rataj <[email protected]> * Update add-on/_locales/en/messages.json Co-authored-by: Marcin Rataj <[email protected]> * Update test/functional/lib/redirect-handler/blockOrObserve.test.ts Co-authored-by: Marcin Rataj <[email protected]> * Update README.md Co-authored-by: Marcin Rataj <[email protected]> * fix(test): Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :see_no_evil: Don't interrupt websockets and webtransports. Signed-off-by: Nishant Arora <[email protected]> * fix: :pencil2: Rename: ensureDeclrativeNetRequetRuleIsAdded -> ensureDeclarativeNetRequestRuleIsAdded Signed-off-by: Nishant Arora <[email protected]> * fix: :pencil2: Rename: ensureTabRedirected -> ensureTabUpdatedTo Signed-off-by: Nishant Arora <[email protected]> * fix(language): :pencil2: Rewrite Signed-off-by: Nishant Arora <[email protected]> * fix(test): :test_tube: Add a failing test. Signed-off-by: Nishant Arora <[email protected]> * Update add-on/_locales/en/messages.json Co-authored-by: Russell Dempsey <[email protected]> * Update ci/update-manifest.sh Co-authored-by: Russell Dempsey <[email protected]> * fix: :pencil2: Beta naming Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): FF Browser Action (#1275) Signed-off-by: Nishant Arora <[email protected]> * test(import): :test_tube: Backfill Tests (#1276) * test(import): :test_tube: Backfill Tests Signed-off-by: Nishant Arora <[email protected]> * Update test/functional/lib/ipfs-import.test.js Co-authored-by: Marcin Rataj <[email protected]> * Update test/functional/lib/ipfs-import.test.js Co-authored-by: Marcin Rataj <[email protected]> * test(import): :test_tube: Backfilling tests for copyImportResultsToFiles Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> Co-authored-by: Marcin Rataj <[email protected]> * feat(mv3): :heavy_plus_sign: Adding hash function to generate predict… (#1273) feat(mv3): :heavy_plus_sign: Adding hash function to generate predictable ids. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :wastebasket: Remove redundant lines. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :recycle: opposite functionality `supportsBlock` -> `supportsDeclarativeNetRequest` Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): :twisted_rightwards_arrows: Adding migrations for embedded to external. Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> Co-authored-by: Russell Dempsey <[email protected]> Co-authored-by: Steve Loeppky <[email protected]> Co-authored-by: Marcin Rataj <[email protected]>
whizzzkid
added a commit
that referenced
this pull request
Sep 15, 2023
BREAKING CHANGE: Implements the new MV3 standard for browser extensions. * feat(mv3): Manifest V3 Migration Checklist (#1170) * feat(mv3): :sparkles: MV3 Manifest Migration * fix(mv3): :wastebasket: No longer needed * fix(mv3): :wrench: Corresponding MV3 Changes * feat(mv3): :package: Adding deps * feat(telemetry): Refactor Metrics Tracking from background service_worker (#1172) * feat(telemetry): :recycle: Init Telemetry away from background service_worker. * feat(telemetry): :recycle: Track metrics from page context instead of service_worker context * feat(mv3): :adhesive_bandage: Patch @protobufjs/inquire to not have eval * fix(mv3): :alien: Fixing contextMenus API changes (#1177) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): webpack configs (#1178) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): :wrench: Fixing webpack config * fix(mv3): :adhesive_bandage: Patching debug package and making background sw work. * feat(mv3): ✨ XHR to Fetch Migration (#1179) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): :wrench: Fixing webpack config * fix(mv3): :adhesive_bandage: Patching debug package and making background sw work. * feat(mv3): :sparkles: XMLHttpRequest => fetch * fix(mv3): :construction: Related changes to ipfs-path * fix(mv3): :construction: Other Related changes * fix(mv3): :construction: Changes to companion * fix(mv3): :white_check_mark: Fixing tests to account for async code. * Fix(mv3): Popup Was Broken (#1180) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): :wrench: Fixing webpack config * fix(mv3): :adhesive_bandage: Patching debug package and making background sw work. * feat(mv3): :sparkles: XMLHttpRequest => fetch * fix(mv3): :construction: Related changes to ipfs-path * fix(mv3): :construction: Other Related changes * fix(mv3): :construction: Changes to companion * fix(mv3): :white_check_mark: Fixing tests to account for async code. * feat(mv3): :recycle: Implementing a non-windowed companion instance * fix(mv3): :wastebasket: Removing calls to background page. * fix: :wastebasket: Unneeded debug statement * fix(mv3): :passport_control: Limiting permissions to chrome-extension * Update add-on/src/lib/ipfs-companion.js Co-authored-by: Russell Dempsey <[email protected]> --------- Co-authored-by: Russell Dempsey <[email protected]> * fix(mv3): CI Builds 🏗️ (#1183) * fix(mv3): :adhesive_bandage: package.json * fix(mv3): :rotating_light: Fix Lint * fix(mv3): :green_heart: Manifest version * feat: :adhesive_bandage: temporary building from rc-branch * feat(mv3): blocking by observing (#1181) * feat(mv3): :sparkles: MV3 Manifest Migration * fix(mv3): :wastebasket: No longer needed * fix(mv3): :wrench: Corresponding MV3 Changes * feat(mv3): :package: Adding deps * feat(telemetry): Refactor Metrics Tracking from background service_worker (#1172) * feat(telemetry): :recycle: Init Telemetry away from background service_worker. * feat(telemetry): :recycle: Track metrics from page context instead of service_worker context * feat(mv3): :adhesive_bandage: Patch @protobufjs/inquire to not have eval * fix(mv3): :alien: Fixing contextMenus API changes (#1177) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): webpack configs (#1178) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): :wrench: Fixing webpack config * fix(mv3): :adhesive_bandage: Patching debug package and making background sw work. * feat(mv3): ✨ XHR to Fetch Migration (#1179) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): :wrench: Fixing webpack config * fix(mv3): :adhesive_bandage: Patching debug package and making background sw work. * feat(mv3): :sparkles: XMLHttpRequest => fetch * fix(mv3): :construction: Related changes to ipfs-path * fix(mv3): :construction: Other Related changes * fix(mv3): :construction: Changes to companion * fix(mv3): :white_check_mark: Fixing tests to account for async code. * Fix(mv3): Popup Was Broken (#1180) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): :wrench: Fixing webpack config * fix(mv3): :adhesive_bandage: Patching debug package and making background sw work. * feat(mv3): :sparkles: XMLHttpRequest => fetch * fix(mv3): :construction: Related changes to ipfs-path * fix(mv3): :construction: Other Related changes * fix(mv3): :construction: Changes to companion * fix(mv3): :white_check_mark: Fixing tests to account for async code. * feat(mv3): :recycle: Implementing a non-windowed companion instance * fix(mv3): :wastebasket: Removing calls to background page. * fix: :wastebasket: Unneeded debug statement * fix(mv3): :passport_control: Limiting permissions to chrome-extension * Update add-on/src/lib/ipfs-companion.js Co-authored-by: Russell Dempsey <[email protected]> * fix(types): :label: Refactoring existing type declaration * fix(types): :label: Moving to new types path * feat(types): :sparkles: Adding typescript support for transpilation * feat(mv3): :sparkles: Adding blocking request tester * fix(mv3): :adhesive_bandage: package.json * fix(mv3): :rotating_light: Fix Lint * fix: :rotating_light: fix lint * fix(mv3): :adhesive_bandage: temp fix to build background context * fix(mv3): :necktie: Detection Logic for MV3 world. * feat(mv3): :sparkles: Dynamic RegexSubstitution * fix(types): :arrow_up: Adding .mocharc.json to fix mocha for TS. * fix: :rotating_light: Lint Fix * fix(mv3): :recycle: refactor background.service_worker * feat(mv3): :sparkles: Passing state to BlockOrObserve * fix(recovery): :bug: conditional for recovery * fix: :wastebasket: unneeded @ts-ignore * fix: :bulb: Adding comments * fix: fixing string method. * fix: removing extra space. * fix: removing @ts-nocheck --------- Co-authored-by: Russell Dempsey <[email protected]> * feat(mv3): adding dynamicNetRequest rule reconciliation logic + Firefox Builds (#1186) * feat(mv3): :sparkles: MV3 Manifest Migration * fix(mv3): :wastebasket: No longer needed * fix(mv3): :wrench: Corresponding MV3 Changes * feat(mv3): :package: Adding deps * feat(telemetry): Refactor Metrics Tracking from background service_worker (#1172) * feat(telemetry): :recycle: Init Telemetry away from background service_worker. * feat(telemetry): :recycle: Track metrics from page context instead of service_worker context * feat(mv3): :adhesive_bandage: Patch @protobufjs/inquire to not have eval * fix(mv3): :alien: Fixing contextMenus API changes (#1177) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): webpack configs (#1178) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): :wrench: Fixing webpack config * fix(mv3): :adhesive_bandage: Patching debug package and making background sw work. * feat(mv3): ✨ XHR to Fetch Migration (#1179) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): :wrench: Fixing webpack config * fix(mv3): :adhesive_bandage: Patching debug package and making background sw work. * feat(mv3): :sparkles: XMLHttpRequest => fetch * fix(mv3): :construction: Related changes to ipfs-path * fix(mv3): :construction: Other Related changes * fix(mv3): :construction: Changes to companion * fix(mv3): :white_check_mark: Fixing tests to account for async code. * Fix(mv3): Popup Was Broken (#1180) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): :wrench: Fixing webpack config * fix(mv3): :adhesive_bandage: Patching debug package and making background sw work. * feat(mv3): :sparkles: XMLHttpRequest => fetch * fix(mv3): :construction: Related changes to ipfs-path * fix(mv3): :construction: Other Related changes * fix(mv3): :construction: Changes to companion * fix(mv3): :white_check_mark: Fixing tests to account for async code. * feat(mv3): :recycle: Implementing a non-windowed companion instance * fix(mv3): :wastebasket: Removing calls to background page. * fix: :wastebasket: Unneeded debug statement * fix(mv3): :passport_control: Limiting permissions to chrome-extension * Update add-on/src/lib/ipfs-companion.js Co-authored-by: Russell Dempsey <[email protected]> * fix(types): :label: Refactoring existing type declaration * fix(types): :label: Moving to new types path * feat(types): :sparkles: Adding typescript support for transpilation * feat(mv3): :sparkles: Adding blocking request tester * fix(mv3): :adhesive_bandage: package.json * fix(mv3): :rotating_light: Fix Lint * fix: :rotating_light: fix lint * fix(mv3): :adhesive_bandage: temp fix to build background context * fix(mv3): :necktie: Detection Logic for MV3 world. * feat(mv3): :sparkles: Dynamic RegexSubstitution * fix(types): :arrow_up: Adding .mocharc.json to fix mocha for TS. * fix: :rotating_light: Lint Fix * fix(mv3): :recycle: refactor background.service_worker * feat(mv3): :sparkles: Passing state to BlockOrObserve * fix(recovery): :bug: conditional for recovery * fix: :wastebasket: unneeded @ts-ignore * fix: :bulb: Adding comments * fix: fixing string method. * fix: removing extra space. * fix: removing @ts-nocheck * no longer needed * fix(mv3): :recycle: Refactor * feat(mv3): :sparkles: Adding rule-recon logic * saving state * fix(mv3): :wrench: Manifest * fix(mv3): :wrench: Fixing firefox webpack config * fix(mv3): :adhesive_bandage: Patching debug to use in memory store instead of browser.storage.local * fix: :rotating_light: fixing lint and moving from record type to map type. * fix: :memo: Adding docstrings. * fix(mv3): :poop: web-ext making things harder than it needs to be. * fix(mv3): :rewind: no more debug patching * fix(mv3): :poop: improved recon logic * fix: :memo: adding comments regarding debug. * fix: :rotating_light: Fix lint * fix(mv3): :passport_control: manifest perms * fix: :wastebasket: unnecessary blank line * feat(mv3): :test_tube: Adding initial tests * feat(mv3): :clown_face: Adding Mock DeclarativeNetRequest Implementation * nits * fix: adding more test examples * fix: self-documenting code. * fix: unneeded comment * Update test/functional/lib/redirect-handler/blockOrObserve.test.ts --------- Co-authored-by: Russell Dempsey <[email protected]> * Chore(mv3-release): Publishing RC releases (#1192) * feat(mv3): :sparkles: MV3 Manifest Migration * fix(mv3): :wastebasket: No longer needed * fix(mv3): :wrench: Corresponding MV3 Changes * feat(mv3): :package: Adding deps * feat(telemetry): Refactor Metrics Tracking from background service_worker (#1172) * feat(telemetry): :recycle: Init Telemetry away from background service_worker. * feat(telemetry): :recycle: Track metrics from page context instead of service_worker context * feat(mv3): :adhesive_bandage: Patch @protobufjs/inquire to not have eval * fix(mv3): :alien: Fixing contextMenus API changes (#1177) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): webpack configs (#1178) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): :wrench: Fixing webpack config * fix(mv3): :adhesive_bandage: Patching debug package and making background sw work. * feat(mv3): ✨ XHR to Fetch Migration (#1179) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): :wrench: Fixing webpack config * fix(mv3): :adhesive_bandage: Patching debug package and making background sw work. * feat(mv3): :sparkles: XMLHttpRequest => fetch * fix(mv3): :construction: Related changes to ipfs-path * fix(mv3): :construction: Other Related changes * fix(mv3): :construction: Changes to companion * fix(mv3): :white_check_mark: Fixing tests to account for async code. * Fix(mv3): Popup Was Broken (#1180) * fix(mv3): :alien: Fixing contextMenus API changes * fix(mv3): :adhesive_bandage: Fixing the browser.action api * fix(mv3): :wrench: Fixing webpack config * fix(mv3): :adhesive_bandage: Patching debug package and making background sw work. * feat(mv3): :sparkles: XMLHttpRequest => fetch * fix(mv3): :construction: Related changes to ipfs-path * fix(mv3): :construction: Other Related changes * fix(mv3): :construction: Changes to companion * fix(mv3): :white_check_mark: Fixing tests to account for async code. * feat(mv3): :recycle: Implementing a non-windowed companion instance * fix(mv3): :wastebasket: Removing calls to background page. * fix: :wastebasket: Unneeded debug statement * fix(mv3): :passport_control: Limiting permissions to chrome-extension * Update add-on/src/lib/ipfs-companion.js Co-authored-by: Russell Dempsey <[email protected]> * fix(types): :label: Refactoring existing type declaration * fix(types): :label: Moving to new types path * feat(types): :sparkles: Adding typescript support for transpilation * feat(mv3): :sparkles: Adding blocking request tester * fix(mv3): :adhesive_bandage: package.json * fix(mv3): :rotating_light: Fix Lint * fix: :rotating_light: fix lint * fix(mv3): :adhesive_bandage: temp fix to build background context * fix(mv3): :necktie: Detection Logic for MV3 world. * feat(mv3): :sparkles: Dynamic RegexSubstitution * fix(types): :arrow_up: Adding .mocharc.json to fix mocha for TS. * fix: :rotating_light: Lint Fix * fix(mv3): :recycle: refactor background.service_worker * feat(mv3): :sparkles: Passing state to BlockOrObserve * fix(recovery): :bug: conditional for recovery * fix: :wastebasket: unneeded @ts-ignore * fix: :bulb: Adding comments * fix: fixing string method. * fix: removing extra space. * fix: removing @ts-nocheck * no longer needed * fix(mv3): :recycle: Refactor * feat(mv3): :sparkles: Adding rule-recon logic * saving state * fix(mv3): :wrench: Manifest * fix(mv3): :wrench: Fixing firefox webpack config * fix(mv3): :adhesive_bandage: Patching debug to use in memory store instead of browser.storage.local * fix: :rotating_light: fixing lint and moving from record type to map type. * fix: :memo: Adding docstrings. * fix(mv3): :poop: web-ext making things harder than it needs to be. * fix(mv3): :rewind: no more debug patching * fix(mv3): :poop: improved recon logic * fix: :memo: adding comments regarding debug. * fix: :rotating_light: Fix lint * fix(mv3): :passport_control: manifest perms * fix: :wastebasket: unnecessary blank line * feat(mv3): :test_tube: Adding initial tests * feat(mv3): :clown_face: Adding Mock DeclarativeNetRequest Implementation * nits * fix: adding more test examples * fix: self-documenting code. * fix: unneeded comment * Creating RC Releases --------- Co-authored-by: Russell Dempsey <[email protected]> * fix(mv3): ref_name (#1193) * Fix/mv3 release (#1194) * fix(mv3): ref_name * fix: this is hard to test * Fixing beta builds * fix(mv3): :bug: Bad Regex for DNS links (#1198) * fix(mv3): :bug: Fixing copy functionality for MV3 (#1197) * fix(mv3): :bug: Fixing copy functionality for MV3 * fix: * Update add-on/src/lib/copier.js * feat(mv3): Handle State Changes (#1200) * fix(mv3): Add support for global toggle on/off * feat(mv3): Handle State Changes * fix(mv3): :recycle: Refactoring code to only message self in observation mode. * Fix/1202 first page is missing content (#1208) * fix: :arrow_up: package-lock * feat(mv3): :recycle: Reload tabs with request url. * fix(mv3): 👔 Adding better regex replace to remove infinite redirects. (#1210) * fix(mv3): :necktie: Adding better regex replace to remove infinite redirects. * fix(mv3): :test_tube: Adding more tests to account for local redirects * fix: :rotating_light: Linter * feat(mv3): :clown_face: DeclarativeNetRequestMock (#1211) * fix(mv3): :necktie: Adding better regex replace to remove infinite redirects. * fix(mv3): :test_tube: Adding more tests to account for local redirects * feat(mv3): :clown_face: DeclarativeNetRequestMock * fix: :rotating_light: Linter * feat(mv3): Adding ContextMenus MV3 Style (#1213) * feat(mv3): :sparkles: ContextMenus MV3 Style * feat(mv3): :test_tube: Adding tests * fix: test case * fix (quick-import): Duplicate behaviour in MV3 (#1215) * feat(mv3): :sparkles: ContextMenus MV3 Style * feat(mv3): :test_tube: Adding tests * fix: test case * fix(mv3): :bug: Quick Import * fix(mv3): :wastebasket: Removing Unnecessary Listener (#1219) * fix: Automatic Mode Description (#1224) * fix: :adhesive_bandage: Adding Automatic Mode Description * Update add-on/_locales/en/messages.json Co-authored-by: Steve Loeppky <[email protected]> * Update add-on/_locales/en/messages.json Co-authored-by: Steve Loeppky <[email protected]> --------- Co-authored-by: Steve Loeppky <[email protected]> * fix: 🗑️ Remove Embedded Node Type (#1225) * fix: :wastebasket: no longer needed Signed-off-by: Nishant Arora <[email protected]> * fix: :wastebasket: unneeded messages Signed-off-by: Nishant Arora <[email protected]> * fix: :wastebasket: Removing unneeded test Signed-off-by: Nishant Arora <[email protected]> * fix: :necktie: Update logic or add todos to fix this later. Signed-off-by: Nishant Arora <[email protected]> * fix: :wastebasket: remove logos Signed-off-by: Nishant Arora <[email protected]> * fix: lint warning Signed-off-by: Nishant Arora <[email protected]> * fix: :alien: no idea why this is a problem now. Signed-off-by: Nishant Arora <[email protected]> * fix: :wastebasket: irrelevant Signed-off-by: Nishant Arora <[email protected]> * fix: quick-import Signed-off-by: Nishant Arora <[email protected]> * fix: Fixing quick-import Signed-off-by: Nishant Arora <[email protected]> * fix: Fixing Tools Signed-off-by: Nishant Arora <[email protected]> * fix: fixing gateway-form Signed-off-by: Nishant Arora <[email protected]> * fix: content-action Signed-off-by: Nishant Arora <[email protected]> * fix: store Signed-off-by: Nishant Arora <[email protected]> * fix: Fixing state Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> * Fix(docs): ✏️ Adding/Updating docs (#1230) * fix(docs): :pencil2: Api -> kubo rpc api Signed-off-by: Nishant Arora <[email protected]> * fix(docs): :pencil2: reword Signed-off-by: Nishant Arora <[email protected]> * fix(docs): :heavy_plus_sign: Adding MV3 Migration Docs and Assets. Signed-off-by: Nishant Arora <[email protected]> * Update docs/MV3.md Co-authored-by: Russell Dempsey <[email protected]> * Update docs/MV3.md Co-authored-by: Russell Dempsey <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> Co-authored-by: Russell Dempsey <[email protected]> * feat(metrics): ✨ Adding patched analytics. (#1232) * feat(mv3): :sparkles: Patching countly-sdk-web Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): :sparkles: Implementing Custom Async Store. Signed-off-by: Nishant Arora <[email protected]> * chore(mv3): :adhesive_bandage: Hooking everything up together. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): Countly Patching + [email protected] Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :adhesive_bandage: Patching the Patch Signed-off-by: Nishant Arora <[email protected]> * fix: tests Signed-off-by: Nishant Arora <[email protected]> * fix: lint Signed-off-by: Nishant Arora <[email protected]> * fix: :adhesive_bandage: Patching error messages Signed-off-by: Nishant Arora <[email protected]> * fix(patch): countly-web-sdk * fix(patch): :pin: Pinning countly-web-sdk to 23.2.2 --------- Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :art: Replacing Static Images with Mermaid Diagrams (#1233) * fic(mv3): :art: Replacing Static Images with Mermaid Diagrams * fix(mv3): :pencil2: Improving Grammar Signed-off-by: Nishant Arora <[email protected]> * Adding Colors Co-authored-by: Russell Dempsey <[email protected]> * Update docs/MV3.md --------- Signed-off-by: Nishant Arora <[email protected]> Co-authored-by: Russell Dempsey <[email protected]> * feat(mv3): Faster Redirects During The First Page Load in main_frame (#1239) * feat(mv3): :zap: Faster redirects for the first time. Signed-off-by: Nishant Arora <[email protected]> * fix: removing only from the tests Signed-off-by: Nishant Arora <[email protected]> * test(mv3): Adding removing rule example. Signed-off-by: Nishant Arora <[email protected]> * test(mv3): :test_tube: Added test regarding removal of rules Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> * fix(telemetry): Reverting to old state of things (#1242) * fix(mv3): Reverting Telemetry Changes To Use PatchedCountlySDK Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): metrics build Signed-off-by: Nishant Arora <[email protected]> * fix: more reverts + fixing patch Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :adhesive_bandage: Patching the Patch Signed-off-by: Nishant Arora <[email protected]> * fix(countly): :adhesive_bandage: don't look for debug, just log it. Signed-off-by: Nishant Arora <[email protected]> * fix(countly): removing session start/end. Signed-off-by: Nishant Arora <[email protected]> * fix: unused var Signed-off-by: Nishant Arora <[email protected]> * fix(countly): patch * revert * fix(countly): repatch, old one seems to be failing. * fix(countly): bad patch * revert * retrying patch * fix: patch files should not be cached. Signed-off-by: Nishant Arora <[email protected]> * fix: fixing cache keys Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): ✨ Introduces Redirect Rule Management (#1240) * feat: exporting rules ending regex Signed-off-by: Nishant Arora <[email protected]> * feat: :sparkles: Adding Rule Management UI Signed-off-by: Nishant Arora <[email protected]> * feat: :sparkles: hooking up with background worker. Signed-off-by: Nishant Arora <[email protected]> * fix: lint Signed-off-by: Nishant Arora <[email protected]> * fix: :art: button styling Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :lipstick: Making UI a bit better Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): Tracking URL resolved/observed count. (#1245) * fix(mv3): Reverting Telemetry Changes To Use PatchedCountlySDK Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): metrics build Signed-off-by: Nishant Arora <[email protected]> * fix: more reverts + fixing patch Signed-off-by: Nishant Arora <[email protected]> * feat: adding request view. Signed-off-by: Nishant Arora <[email protected]> * Reverting to mainline rc patch * Reverting to mainline rc add-on/src/lib/ipfs-companion.js * feat(telemetry): Signed-off-by: Nishant Arora <[email protected]> * feat(telemetry): Implementing RequestTracker Event Handler Signed-off-by: Nishant Arora <[email protected]> * feat(telemetry): hooking up events. Signed-off-by: Nishant Arora <[email protected]> * fix(types): annotations * fix(telemetry): :wastebasket: returning to previous state Signed-off-by: Nishant Arora <[email protected]> * fix(telemetry): :recycle: Refactor Request Tracker Signed-off-by: Nishant Arora <[email protected]> * fix(telemetry): hooking up requests Signed-off-by: Nishant Arora <[email protected]> * fix(telemetry): better types Signed-off-by: Nishant Arora <[email protected]> * fix(countly): :wastebasket: more stuff goes, because test need to pass. Signed-off-by: Nishant Arora <[email protected]> * fix(lint): fixed * feat(test): test tracker. * fix: remove only Signed-off-by: Nishant Arora <[email protected]> * fix: :lipstick: line break Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): Ask for Host Permissions if not exist. (#1250) * feat(mv3): :sparkles: Requesting Host Permissions Explicitly Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): :bug: Adding perms step on installed. Signed-off-by: Nishant Arora <[email protected]> * fix: request-permission-view tracking Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): Making permissions agnostic to browser Signed-off-by: Nishant Arora <[email protected]> * docs: clarify why we need host permission making prompt less scary, shorter, and informative * Update add-on/src/lib/ipfs-request.js Co-authored-by: Marcin Rataj <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> Co-authored-by: Marcin Rataj <[email protected]> * feat(mv3): Redirection Tests (#1236) * feat(mv3): :sparkles: Patching countly-sdk-web Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): :sparkles: Implementing Custom Async Store. Signed-off-by: Nishant Arora <[email protected]> * chore(mv3): :adhesive_bandage: Hooking everything up together. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): Countly Patching + [email protected] Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :adhesive_bandage: Patching the Patch Signed-off-by: Nishant Arora <[email protected]> * fix: tests Signed-off-by: Nishant Arora <[email protected]> * fix: lint Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :recycle: Refactoring `supportsBlock` Checks. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): Regex Bug Signed-off-by: Nishant Arora <[email protected]> * feat: Migrating blocking redirection test to observing redirection test Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :wrench: Fixing the mocha-setup. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :recycle: Moving Setup Files. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): gateway-redirect tests now fixed. Signed-off-by: Nishant Arora <[email protected]> * fix: :adhesive_bandage: Patching error messages Signed-off-by: Nishant Arora <[email protected]> * fix(patch): countly-web-sdk * fix(patch): :pin: Pinning countly-web-sdk to 23.2.2 * fix(mv3): :lipstick: Fixing Lint Signed-off-by: Nishant Arora <[email protected]> * feat: protocol-handler-redirection-tests Signed-off-by: Nishant Arora <[email protected]> * feat: more tests fixed Signed-off-by: Nishant Arora <[email protected]> * fix: More tests Signed-off-by: Nishant Arora <[email protected]> * fix: lint fix Signed-off-by: Nishant Arora <[email protected]> * test: merge mocha-setup files (#1246) * test: merge mocha-setup files * test(helper): add mv3-test-enabled helper * test(setup): remove duplicate setup for mv3/mv2 * test(mv3): merge mv3 tests into mv2 test files (#1247) * test(mv3): merge mv3 tests into mv2 test files * chore(lint): fix lint failures * test(supportsBlock): cleanup test * test: migrating some tests * test(redirect): mv3 tests use same code as mv2 * test(redirect): mv3 test cleanup * test(protohandler): mv3 tests use same code as mv2 * test(helper): make isMv3 flag a boolean * test: fix after merge * test: fix after merge * fix: typerrors for localstorage Signed-off-by: Nishant Arora <[email protected]> * fix: Updating test:functional_MV3 command. Signed-off-by: Nishant Arora <[email protected]> * fix: setup Signed-off-by: Nishant Arora <[email protected]> * fix(test): Fixing tests Signed-off-by: Nishant Arora <[email protected]> * fix(lint): Becuase Ofcourse * feat(test): scaffolding mv3 + mv2 calls in a single check. Signed-off-by: Nishant Arora <[email protected]> * feat(test): unskipping and upgrading dnslink tests to mv3 Signed-off-by: Nishant Arora <[email protected]> * feat(test): Upgrading workaround tests to MV3 Signed-off-by: Nishant Arora <[email protected]> * fix(test): removing all skips with better checks. Signed-off-by: Nishant Arora <[email protected]> * fix(test): :recycle: Refactoring tests and removing redundant calls. Signed-off-by: Nishant Arora <[email protected]> * fix(test): More Dryer Signed-off-by: Nishant Arora <[email protected]> * fix(test): one more Signed-off-by: Nishant Arora <[email protected]> * fix(test): :pencil2: Renaming isMv3TestingEnabled -> isManifestV3 Signed-off-by: Nishant Arora <[email protected]> * fix(test): refactor expectNoRedirect Signed-off-by: Nishant Arora <[email protected]> * fix(test): :recycle: Refactoring more. Signed-off-by: Nishant Arora <[email protected]> * fix: replacing checks to undefined Signed-off-by: Nishant Arora <[email protected]> * fix: renaming expectNoRedirect -> ensureNoRedirect Signed-off-by: Nishant Arora <[email protected]> * fix(test): Adding missing JSDoc Signed-off-by: Nishant Arora <[email protected]> * fix(test): :shrug: how did this get removed. Signed-off-by: Nishant Arora <[email protected]> * fix(test): :wastebasket: removed. Signed-off-by: Nishant Arora <[email protected]> * fix(test): Suggestion * fix(test): :adhesive_bandage: Bad Merge Signed-off-by: Nishant Arora <[email protected]> * fix(test): sequential expectNoRedirect * Update add-on/src/lib/redirect-handler/blockOrObserve.ts Co-authored-by: Marcin Rataj <[email protected]> * fix(rules): Better Redirect Rules (#1256) * fix(mv3): :wrench: Modifying the default local redirect behaviour. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :wrench: Modifying the default local redirect behaviour. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :bug: Making rules less greedy Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :sparkles: Dynamic Rules for subdomain gateways. Signed-off-by: Nishant Arora <[email protected]> * fix(types): Adding ambient types for is-ipfs. Signed-off-by: Nishant Arora <[email protected]> * fix(test): Signed-off-by: Nishant Arora <[email protected]> * fix(test): helper Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): less greedy rules Signed-off-by: Nishant Arora <[email protected]> * feat: Adding simpler regex for redirects from similar namespaces. Signed-off-by: Nishant Arora <[email protected]> * fix(lint): :rotating_light: Warnings Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): Better Default Rules (#1260) * refactor(mv3): blockOrRequest code Signed-off-by: Nishant Arora <[email protected]> * refactor(mv3): Port Logic for Default Rules is more robust. Signed-off-by: Nishant Arora <[email protected]> * feat(test): Adding tests for default rule logic. Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> * Update add-on/src/lib/redirect-handler/blockOrObserve.ts * fix(docs): :pencil2: Adding comments Signed-off-by: Nishant Arora <[email protected]> * refactor(regexfilters): Better Structure and Readability (#1261) * refactor(regexFilters): :sparkles: Adding a base class for regexFilters. Signed-off-by: Nishant Arora <[email protected]> * refactor(regexFilters): :recycle: Moving subdomain filter to a subclass Signed-off-by: Nishant Arora <[email protected]> * refactor(regexFilters): :recycle: Moving namespace filter to a subclass Signed-off-by: Nishant Arora <[email protected]> * refactor(regexFilters): :recycle: Moving common filter to a subclass Signed-off-by: Nishant Arora <[email protected]> * feat(regexFilters): :sparkles: Hooking Up All together Signed-off-by: Nishant Arora <[email protected]> * fix(lint): :pencil2: Lint Signed-off-by: Nishant Arora <[email protected]> * fix(regexFilters): :pencil2: Updating message. Signed-off-by: Nishant Arora <[email protected]> * fix(rename): :pencil2: CommonPatterRedirectRegexFilter -> CommonPatternRedirectRegexFilter Signed-off-by: Nishant Arora <[email protected]> * fix(regexFilters): :recycle: Refactor to remove call to super Signed-off-by: Nishant Arora <[email protected]> * fix: make _canHandle private Signed-off-by: Nishant Arora <[email protected]> * fix: :zap: Fix math.min on every loop. Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): no blanket redirect for subdomains without namespaces. Signed-off-by: Nishant Arora <[email protected]> * fix(lint): unused import Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> Co-authored-by: Russell Dempsey <[email protected]> Co-authored-by: Marcin Rataj <[email protected]> * fix(recovery): Recovery Rules should reset (#1266) * feat(mv3): :sparkles: Patching countly-sdk-web Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): :sparkles: Implementing Custom Async Store. Signed-off-by: Nishant Arora <[email protected]> * chore(mv3): :adhesive_bandage: Hooking everything up together. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): Countly Patching + [email protected] Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :adhesive_bandage: Patching the Patch Signed-off-by: Nishant Arora <[email protected]> * fix: tests Signed-off-by: Nishant Arora <[email protected]> * fix: lint Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :recycle: Refactoring `supportsBlock` Checks. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): Regex Bug Signed-off-by: Nishant Arora <[email protected]> * feat: Migrating blocking redirection test to observing redirection test Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :wrench: Fixing the mocha-setup. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :recycle: Moving Setup Files. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): gateway-redirect tests now fixed. Signed-off-by: Nishant Arora <[email protected]> * fix: :adhesive_bandage: Patching error messages Signed-off-by: Nishant Arora <[email protected]> * fix(patch): countly-web-sdk * fix(patch): :pin: Pinning countly-web-sdk to 23.2.2 * fix(mv3): :lipstick: Fixing Lint Signed-off-by: Nishant Arora <[email protected]> * feat: protocol-handler-redirection-tests Signed-off-by: Nishant Arora <[email protected]> * feat: more tests fixed Signed-off-by: Nishant Arora <[email protected]> * fix: More tests Signed-off-by: Nishant Arora <[email protected]> * fix: lint fix Signed-off-by: Nishant Arora <[email protected]> * test: merge mocha-setup files (#1246) * test: merge mocha-setup files * test(helper): add mv3-test-enabled helper * test(setup): remove duplicate setup for mv3/mv2 * test(mv3): merge mv3 tests into mv2 test files (#1247) * test(mv3): merge mv3 tests into mv2 test files * chore(lint): fix lint failures * test(supportsBlock): cleanup test * test: migrating some tests * test(redirect): mv3 tests use same code as mv2 * test(redirect): mv3 test cleanup * test(protohandler): mv3 tests use same code as mv2 * test(helper): make isMv3 flag a boolean * test: fix after merge * test: fix after merge * fix: typerrors for localstorage Signed-off-by: Nishant Arora <[email protected]> * fix: Updating test:functional_MV3 command. Signed-off-by: Nishant Arora <[email protected]> * fix: setup Signed-off-by: Nishant Arora <[email protected]> * fix(test): Fixing tests Signed-off-by: Nishant Arora <[email protected]> * fix(lint): Becuase Ofcourse * feat(test): scaffolding mv3 + mv2 calls in a single check. Signed-off-by: Nishant Arora <[email protected]> * feat(test): unskipping and upgrading dnslink tests to mv3 Signed-off-by: Nishant Arora <[email protected]> * feat(test): Upgrading workaround tests to MV3 Signed-off-by: Nishant Arora <[email protected]> * fix(test): removing all skips with better checks. Signed-off-by: Nishant Arora <[email protected]> * fix(test): :recycle: Refactoring tests and removing redundant calls. Signed-off-by: Nishant Arora <[email protected]> * fix(test): More Dryer Signed-off-by: Nishant Arora <[email protected]> * fix(test): one more Signed-off-by: Nishant Arora <[email protected]> * fix(test): :pencil2: Renaming isMv3TestingEnabled -> isManifestV3 Signed-off-by: Nishant Arora <[email protected]> * fix(test): refactor expectNoRedirect Signed-off-by: Nishant Arora <[email protected]> * fix(test): :recycle: Refactoring more. Signed-off-by: Nishant Arora <[email protected]> * fix: replacing checks to undefined Signed-off-by: Nishant Arora <[email protected]> * fix: renaming expectNoRedirect -> ensureNoRedirect Signed-off-by: Nishant Arora <[email protected]> * fix(test): Adding missing JSDoc Signed-off-by: Nishant Arora <[email protected]> * fix(test): :shrug: how did this get removed. Signed-off-by: Nishant Arora <[email protected]> * fix(test): :wastebasket: removed. Signed-off-by: Nishant Arora <[email protected]> * fix(test): Suggestion * fix(test): :adhesive_bandage: Bad Merge Signed-off-by: Nishant Arora <[email protected]> * fix(test): sequential expectNoRedirect * Update add-on/src/lib/redirect-handler/blockOrObserve.ts Co-authored-by: Marcin Rataj <[email protected]> * fix(mv3): :wrench: Modifying the default local redirect behaviour. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :wrench: Modifying the default local redirect behaviour. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :bug: Making rules less greedy Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :sparkles: Dynamic Rules for subdomain gateways. Signed-off-by: Nishant Arora <[email protected]> * fix(types): Adding ambient types for is-ipfs. Signed-off-by: Nishant Arora <[email protected]> * fix(test): Signed-off-by: Nishant Arora <[email protected]> * fix(test): helper Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): less greedy rules Signed-off-by: Nishant Arora <[email protected]> * feat: Adding simpler regex for redirects from similar namespaces. Signed-off-by: Nishant Arora <[email protected]> * fix(lint): :rotating_light: Warnings Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): Better Default Rules (#1260) * refactor(mv3): blockOrRequest code Signed-off-by: Nishant Arora <[email protected]> * refactor(mv3): Port Logic for Default Rules is more robust. Signed-off-by: Nishant Arora <[email protected]> * feat(test): Adding tests for default rule logic. Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> * Update add-on/src/lib/redirect-handler/blockOrObserve.ts * fix(docs): :pencil2: Adding comments Signed-off-by: Nishant Arora <[email protected]> * refactor(regexFilters): :sparkles: Adding a base class for regexFilters. Signed-off-by: Nishant Arora <[email protected]> * refactor(regexFilters): :recycle: Moving subdomain filter to a subclass Signed-off-by: Nishant Arora <[email protected]> * refactor(regexFilters): :recycle: Moving namespace filter to a subclass Signed-off-by: Nishant Arora <[email protected]> * refactor(regexFilters): :recycle: Moving common filter to a subclass Signed-off-by: Nishant Arora <[email protected]> * feat(regexFilters): :sparkles: Hooking Up All together Signed-off-by: Nishant Arora <[email protected]> * fix(lint): :pencil2: Lint Signed-off-by: Nishant Arora <[email protected]> * fix(regexFilters): :pencil2: Updating message. Signed-off-by: Nishant Arora <[email protected]> * fix(rename): :pencil2: CommonPatterRedirectRegexFilter -> CommonPatternRedirectRegexFilter Signed-off-by: Nishant Arora <[email protected]> * fix(regexFilters): :recycle: Refactor to remove call to super Signed-off-by: Nishant Arora <[email protected]> * fix: make _canHandle private Signed-off-by: Nishant Arora <[email protected]> * fix: :zap: Fix math.min on every loop. Signed-off-by: Nishant Arora <[email protected]> * fix(recovery): reset rules Signed-off-by: Nishant Arora <[email protected]> * fix(recovery): :recycle: Refactor messaging logic Signed-off-by: Nishant Arora <[email protected]> * fix(recovery): :bug: Cleanup Logic Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :bug: fix toggle site integration. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :adhesive_bandage: Hard coding wait as the browser is not cooperative. Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> Co-authored-by: Russell Dempsey <[email protected]> Co-authored-by: Marcin Rataj <[email protected]> * fix(mv3): :bug: rules section visible. (#1271) Signed-off-by: Nishant Arora <[email protected]> * fix(brave): Fix Brave UX (#1270) * fix(options): fixing options menu Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): Adding brave specific redirects. Signed-off-by: Nishant Arora <[email protected]> * fix: lint Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> * feat(e2e): Request Handling Tests (#1272) * fix(test): :recycle: simplify scaffolding Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): :test_tube: Adding a final resolution check Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> * Update add-on/_locales/en/messages.json Co-authored-by: Marcin Rataj <[email protected]> * Update add-on/src/options/forms/api-form.js Co-authored-by: Marcin Rataj <[email protected]> * Update add-on/_locales/en/messages.json Co-authored-by: Marcin Rataj <[email protected]> * Update test/functional/lib/redirect-handler/blockOrObserve.test.ts Co-authored-by: Marcin Rataj <[email protected]> * Update README.md Co-authored-by: Marcin Rataj <[email protected]> * fix(test): Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :see_no_evil: Don't interrupt websockets and webtransports. Signed-off-by: Nishant Arora <[email protected]> * fix: :pencil2: Rename: ensureDeclrativeNetRequetRuleIsAdded -> ensureDeclarativeNetRequestRuleIsAdded Signed-off-by: Nishant Arora <[email protected]> * fix: :pencil2: Rename: ensureTabRedirected -> ensureTabUpdatedTo Signed-off-by: Nishant Arora <[email protected]> * fix(language): :pencil2: Rewrite Signed-off-by: Nishant Arora <[email protected]> * fix(test): :test_tube: Add a failing test. Signed-off-by: Nishant Arora <[email protected]> * Update add-on/_locales/en/messages.json Co-authored-by: Russell Dempsey <[email protected]> * Update ci/update-manifest.sh Co-authored-by: Russell Dempsey <[email protected]> * fix: :pencil2: Beta naming Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): FF Browser Action (#1275) Signed-off-by: Nishant Arora <[email protected]> * test(import): :test_tube: Backfill Tests (#1276) * test(import): :test_tube: Backfill Tests Signed-off-by: Nishant Arora <[email protected]> * Update test/functional/lib/ipfs-import.test.js Co-authored-by: Marcin Rataj <[email protected]> * Update test/functional/lib/ipfs-import.test.js Co-authored-by: Marcin Rataj <[email protected]> * test(import): :test_tube: Backfilling tests for copyImportResultsToFiles Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> Co-authored-by: Marcin Rataj <[email protected]> * feat(mv3): :heavy_plus_sign: Adding hash function to generate predict… (#1273) feat(mv3): :heavy_plus_sign: Adding hash function to generate predictable ids. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :wastebasket: Remove redundant lines. Signed-off-by: Nishant Arora <[email protected]> * fix(mv3): :recycle: opposite functionality `supportsBlock` -> `supportsDeclarativeNetRequest` Signed-off-by: Nishant Arora <[email protected]> * feat(mv3): :twisted_rightwards_arrows: Adding migrations for embedded to external. Signed-off-by: Nishant Arora <[email protected]> --------- Signed-off-by: Nishant Arora <[email protected]> Co-authored-by: Russell Dempsey <[email protected]> Co-authored-by: Steve Loeppky <[email protected]> Co-authored-by: Marcin Rataj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1212
In this PR: