Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Kubo - Companion Docs #1265

Open
2 tasks done
whizzzkid opened this issue Jun 12, 2023 · 2 comments
Open
2 tasks done

Improve Kubo - Companion Docs #1265

whizzzkid opened this issue Jun 12, 2023 · 2 comments
Labels
need/triage Needs initial labeling and prioritization

Comments

@whizzzkid
Copy link
Contributor

Checklist

Location

No response

Description

A few interesting points came up: https://www.reddit.com/r/ipfs/comments/145inx4/just_tried_ipfs_a_few_thoughts/

I believe we should cover possible scenarios and setup guides to make pairing companion with kubo easy.

  1. cover different setup types.
  2. cover a few possible scenarios.
  3. issues around CORS issue.

relates to:

@whizzzkid whizzzkid added the need/triage Needs initial labeling and prioritization label Jun 12, 2023
@lidel
Copy link
Member

lidel commented Aug 21, 2023

I'm moving this back to ipfs-companion, as it does not seem to be actionable from the perspective of Kubo repository
(imo Kubo repo should not have documentation related to companion, just like we don't have anything about ipfs-desktop, ipfsd-ctl, ipfs-cluster or any other project that uses Kubo – such docs belong to repo of respective project)


As for configuring Companion to work with non-localhost node, my suggestion is to be conservative:

  • Companion is a GUI application that should "just work"
  • We should NOT ask people to set CORS headers for ipfs-companion to function correctly
    • Setting CORS to safelist RPC port access is hard for a reason: this is a power user feature that comes with security risk, VERY easy to give admin access to RPC port to every website on the internet.
      • Kubo has no access control mechanism beyond CORS atm, and until some way of guarding it like API Tokens kubo#1532 is resolved, using RPC outside a controlled environment of localhost is considered a power user feature, aka "use at your own risk".

👉 By looking at the reddit post, it sounds like what IPFS Companion could do, is to have more meaningful error message when non-localhost RPC or Gateway is used. It should explain security (CORS giving admin access to RPC API) and/or interop ramifications (non-localhost cleartext http:// gateway causing mixed-content errors IF subresources are redirected).

[..] shows ipfs not running even though I am using a kubo rpc install on the local network. #

This sounds like a bug?

@lidel lidel transferred this issue from ipfs/kubo Aug 21, 2023
@lidel lidel removed their assignment Aug 21, 2023
@lidel lidel added need/triage Needs initial labeling and prioritization and removed need/triage Needs initial labeling and prioritization labels Sep 4, 2023
@crotel
Copy link

crotel commented Mar 28, 2024

How about add virtual network for API isolation. like through zerotier-like intranet for using api remotely, while local computer at same network, then put the other ports public if one-self wanted, which like gateway, swarm etc,.?
maybe this way should link the cluster together in more safe way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

3 participants