-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipfs://CIDv0 (ipfs://Qm…) becomes lowercase and doesn't work on firefox 89 #1006
Comments
Thank you for reporting this. Unfortunately, the lowercasing is performed by Firefox before URL is passed to gateway or can be converted to CIDv1 by Companion, so we can't do anything about it. You should follow the advice from the error message and convert CID to case-insensitive base32. In near future this issue will be less prominent because we are going to switch to CIDv1 in base32 as the default (ipfs/kubo#4143) |
Has anyone gotten in touch with Mozilla about this? Perhaps they could be trivially alleviate this issue on their end. Obviously CIDv1 is the solution going forward but there are lots of CIDv0 links still out there. My first real contact with IPFS happened just a few minutes ago and it was a CIDv0 which then triggered this issue. It's not a huge problem since linkifying ipfs URLs usually obviates the need for pasting one into the browser bar but that's not enabled by default. I also got a very user-unfriendly error message which isn't great:
|
It is not just Mozilla, other apps and libraries force-lowercase on URIs as well. The best we can do for CIDv0 is to improve error message when they get broken by a forced lowercase. |
When accessing ipfs://QmUVTKsrYJpaxUT7dr9FpKq6AoKHhEM7eG1ZHGL56haKLG, the link is converted to lowercase, and an error message appears because of that.
To Reproduce
ipfs daemon
on the command-lineipfs://QmUVTKsrYJpaxUT7dr9FpKq6AoKHhEM7eG1ZHGL56haKLG
ipfs://qmuvtksryjpaxut7dr9fpkq6aokhhem7eg1zhgl56haklg
and then tohttps://dweb.link/ipfs/qmuvtksryjpaxut7dr9fpkq6aokhhem7eg1zhgl56haklg
which shows the following error:Expected behaviour
The URL should stay
ipfs://QmUVTKsrYJpaxUT7dr9FpKq6AoKHhEM7eG1ZHGL56haKLG
or be converted tohttp://QmUVTKsrYJpaxUT7dr9FpKq6AoKHhEM7eG1ZHGL56haKLG.ipfs.localhost:8080/
or some other proxy, and a page containing the textHello IPFS
should appear.Screenshots
Desktop
ipfs --version
:ipfs version 0.8.0
Additional context
Entering https://dweb.link/ipfs/QmUVTKsrYJpaxUT7dr9FpKq6AoKHhEM7eG1ZHGL56haKLG in the URL bar works (and redirects to http://bafybeic3m55e3k75my22xepbnga5m7gao5dzvtwpnyjkebjqir54dlngfu.ipfs.localhost:8080/)
Entering ipfs://bafybeic3m55e3k75my22xepbnga5m7gao5dzvtwpnyjkebjqir54dlngfu in the URL bar works (and redirects to http://bafybeic3m55e3k75my22xepbnga5m7gao5dzvtwpnyjkebjqir54dlngfu.ipfs.localhost:8080/)
Entering /ipfs/QmUVTKsrYJpaxUT7dr9FpKq6AoKHhEM7eG1ZHGL56haKLG in the URL bar works (and redirects to file:///ipfs/QmUVTKsrYJpaxUT7dr9FpKq6AoKHhEM7eG1ZHGL56haKLG)
Entering /ipfs/bafybeic3m55e3k75my22xepbnga5m7gao5dzvtwpnyjkebjqir54dlngfu in the URL bar works (and redirects to file:///ipfs/bafybeic3m55e3k75my22xepbnga5m7gao5dzvtwpnyjkebjqir54dlngfu)
Entering QmUVTKsrYJpaxUT7dr9FpKq6AoKHhEM7eG1ZHGL56haKLG.ipfs.localhost:8080 in the URL bar DOES NOT WORK (it gets redirected to http://qmuvtksryjpaxut7dr9fpkq6aokhhem7eg1zhgl56haklg.ipfs.localhost:8080/)
Entering bafybeic3m55e3k75my22xepbnga5m7gao5dzvtwpnyjkebjqir54dlngfu.ipfs.localhost:8080 in the URL bar works (and redirects to http://bafybeic3m55e3k75my22xepbnga5m7gao5dzvtwpnyjkebjqir54dlngfu.ipfs.localhost:8080/)
Entering ipfs://ipfs/QmUVTKsrYJpaxUT7dr9FpKq6AoKHhEM7eG1ZHGL56haKLG in the URL bar works (and redirects to http://bafybeic3m55e3k75my22xepbnga5m7gao5dzvtwpnyjkebjqir54dlngfu.ipfs.localhost:8080/)
Entering ipfs://ipfs/bafybeic3m55e3k75my22xepbnga5m7gao5dzvtwpnyjkebjqir54dlngfu in the URL bar works (and redirects to http://bafybeic3m55e3k75my22xepbnga5m7gao5dzvtwpnyjkebjqir54dlngfu.ipfs.localhost:8080/)
Entering ipfs://./QmUVTKsrYJpaxUT7dr9FpKq6AoKHhEM7eG1ZHGL56haKLG in the URL bar works (and redirects to http://bafybeic3m55e3k75my22xepbnga5m7gao5dzvtwpnyjkebjqir54dlngfu.ipfs.localhost:8080/)
Entering ipfs://./bafybeic3m55e3k75my22xepbnga5m7gao5dzvtwpnyjkebjqir54dlngfu in the URL bar works (and redirects to http://bafybeic3m55e3k75my22xepbnga5m7gao5dzvtwpnyjkebjqir54dlngfu.ipfs.localhost:8080/)
Entering ipfs:./QmUVTKsrYJpaxUT7dr9FpKq6AoKHhEM7eG1ZHGL56haKLG in the URL bar works (and redirects to http://bafybeic3m55e3k75my22xepbnga5m7gao5dzvtwpnyjkebjqir54dlngfu.ipfs.localhost:8080/)
Entering ipfs:./bafybeic3m55e3k75my22xepbnga5m7gao5dzvtwpnyjkebjqir54dlngfu in the URL bar works (and redirects to http://bafybeic3m55e3k75my22xepbnga5m7gao5dzvtwpnyjkebjqir54dlngfu.ipfs.localhost:8080/)
A similar issue has been reported in the past, and closed as fixed: #815
The text was updated successfully, but these errors were encountered: