This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Output a more useful resolve error #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This outputs a missage that blames a specific sife for not having DNSLink record. For example, the error message looks like: `could not resolve name: bad.example.net is missing DNSLink record (https://docs.ipfs.io/concepts/dnslink/)` The "could not resolve name" portion is still present because the returned error wraps the original ErrResolveFailed, allowing code to test if the error is an ErrorResolveFailed error.
lidel
approved these changes
Apr 6, 2021
There was a problem hiding this comment.
@gammazero looks good to me, as long we include the fix suggested below.
Co-authored-by: Marcin Rataj <[email protected]>
This was referenced Apr 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This outputs a missage that blames a specific sife for not having DNSLink record. For example, the error message looks like:
The "could not resolve name" portion is still present because the returned error wraps the original
ErrResolveFailed, allowing code to test if the error is anErrResolveFailederror.This addresses go-ipfs issue 8000