-
Notifications
You must be signed in to change notification settings - Fork 30
Needs Review #2
Comments
@Stebalien Could you provide me some more context here please? |
This is an extraction of the IPNS record creation, validation, and sorting logic. This way:
I assigned you because you tend to be very thorough and this code has been historically tricky to get right. Feel free to unassign yourself if you feel you don't have enough context/background with IPNS or feel strapped for time. Also, this isn't exactly pressing. |
IPFS PR: ipfs/kubo#5124 |
Personally I love this package, and have already started using it. It has been so much easier to use this instead of digging around the go-ipfs repo |
@postables thanks! |
Agreed, this is much better. Excited that you're making a big effort to improve IPNS @Stebalien and @whyrusleeping |
I'm (temporarily) unassigning myself from this issue due to my lack of knowledge (and documentation) about IPNS, if someone wants to take it go ahead, if not I'll come back when I'm better prepared for it. |
This repository is no longer maintained and has been copied over to Boxo. We are now in the process of reviewing issues and PRs and moving the ones that are still relevant. This issue has been moved to ipfs/boxo#335. |
This package should be thoroughly reviewed. To make it a bit more general-purpose (less libp2p-record specific), I've refactored it quite a bit.
The text was updated successfully, but these errors were encountered: