Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Needs Review #2

Closed
Stebalien opened this issue Jun 15, 2018 · 8 comments
Closed

Needs Review #2

Stebalien opened this issue Jun 15, 2018 · 8 comments

Comments

@Stebalien
Copy link
Member

This package should be thoroughly reviewed. To make it a bit more general-purpose (less libp2p-record specific), I've refactored it quite a bit.

@schomatis
Copy link

@Stebalien Could you provide me some more context here please?

@Stebalien
Copy link
Member Author

This is an extraction of the IPNS record creation, validation, and sorting logic. This way:

  1. Packages don't have to pull in all of go-ipfs just to validate IPNS records. E.g., dht-node.
  2. Users/developers trying to understand IPNS don't have to fish around the go-ipfs repo.

I assigned you because you tend to be very thorough and this code has been historically tricky to get right. Feel free to unassign yourself if you feel you don't have enough context/background with IPNS or feel strapped for time. Also, this isn't exactly pressing.

@Stebalien
Copy link
Member Author

IPFS PR: ipfs/kubo#5124

@bonedaddy
Copy link
Contributor

Personally I love this package, and have already started using it. It has been so much easier to use this instead of digging around the go-ipfs repo

@Stebalien
Copy link
Member Author

@postables thanks!

@dirkmc
Copy link

dirkmc commented Jun 18, 2018

Agreed, this is much better. Excited that you're making a big effort to improve IPNS @Stebalien and @whyrusleeping

@schomatis
Copy link

schomatis commented Jun 22, 2018

I'm (temporarily) unassigning myself from this issue due to my lack of knowledge (and documentation) about IPNS, if someone wants to take it go ahead, if not I'll come back when I'm better prepared for it.

@schomatis schomatis removed their assignment Jun 22, 2018
@hacdias
Copy link
Member

hacdias commented Jun 6, 2023

This repository is no longer maintained and has been copied over to Boxo. We are now in the process of reviewing issues and PRs and moving the ones that are still relevant. This issue has been moved to ipfs/boxo#335.

@hacdias hacdias closed this as not planned Won't fix, can't repro, duplicate, stale Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

No branches or pull requests

5 participants