-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental dht client #8061
Merged
Merged
Experimental dht client #8061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
force-pushed
the
feat/experimental-dht-client
branch
2 times, most recently
from
May 13, 2021 05:07
3556ad2
to
476444c
Compare
Stebalien
reviewed
May 13, 2021
gammazero
approved these changes
May 13, 2021
aschmahmann
force-pushed
the
feat/experimental-dht-client
branch
from
May 14, 2021 08:18
30b7a2a
to
d9d6ba3
Compare
The experimental AcceleratedDHTClient can be enabled from the config When enabled it modifies the output of the `ipfs stats dht` command.
aschmahmann
force-pushed
the
feat/experimental-dht-client
branch
from
May 14, 2021 08:31
d9d6ba3
to
2fd55d1
Compare
The batched provider system is enabled when the experimental AcceleratedDHTClient is enabled There is also an `ipfs stats provide` command which gives stats about the providing/reproviding system when the batched provider system is enabled
…T Client and batched providing system
alanshaw
reviewed
May 20, 2021
Comment on lines
+47
to
+48
cmds.StringArg("dht", false, true, "The DHT whose table should be listed (wanserver, lanserver, wan, lan). "+ | ||
"wan and lan refer to client routing tables. When using the experimental DHT client only WAN is supported. Defaults to wan and lan."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are wanserver/lanserver and are they new? Can the description explain 🙏
|
||
``` | ||
ipfs config --json Experimental.AcceleratedDHTClient true | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a note that if the daemon is running it must be restarted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature enables an option for an experimental DHT client that makes a few key optimizations over the standard client.
Depends on:
A couple quirks about the current state of this PR and the client:
This PR also includes an experimental provider system which utilizes the experimental dht client and is bundled with it - the originating PR was #8070