Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate Gateway.PathPrefixes #7994

Merged
merged 1 commit into from
Mar 30, 2021
Merged

chore: deprecate Gateway.PathPrefixes #7994

merged 1 commit into from
Mar 30, 2021

Conversation

lidel
Copy link
Member

@lidel lidel commented Mar 20, 2021

Context: #7702 and @Stebalien comments there

This PR deprecates Gateway.PathPrefixes and X-Ipfs-Gateway-Prefix header:

  • marks Gateway.PathPrefixes as deprecated in docs/config.md
  • logs error during startup if Gateway.PathPrefixes is used (not empty)
    • I went with log because it prints red ERROR that makes it hard to miss (but lmk if should be regular stderr instead):

      2021-03-20--01-05-06

@lidel lidel added the topic/gateway Topic gateway label Mar 20, 2021
@lidel lidel requested a review from Stebalien March 20, 2021 00:07
@lidel lidel mentioned this pull request Mar 20, 2021
Closed
Stebalien
Stebalien reviewed Mar 21, 2021
View reviewed changes
cmd/ipfs/daemon.go Outdated Show resolved Hide resolved
cmd/ipfs/daemon.go Outdated Show resolved Hide resolved
@lidel lidel added this to the go-ipfs 0.9 milestone Mar 30, 2021
@lidel lidel force-pushed the chore/deprecate-pathprefixes branch from 3e81d6a to 2f105f7 Compare March 30, 2021 19:18
@lidel lidel requested a review from Stebalien March 30, 2021 19:18
@lidel
Copy link
Member Author

lidel commented Mar 30, 2021

@Stebalien applied your suggestions, should be ready for final review & merge.

@Stebalien Stebalien merged commit 0a3f888 into master Mar 30, 2021
@Stebalien Stebalien deleted the chore/deprecate-pathprefixes branch March 30, 2021 22:52
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
Closed
71 tasks
@lidel lidel mentioned this pull request Mar 20, 2022
Closed
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 27, 2023
@Stebalien
Merge pull request ipfs/kubo#7994 from ipfs/chore/deprecate-pathprefixes
d39e618 
chore: deprecate Gateway.PathPrefixes

This commit was moved from ipfs/kubo@0a3f888
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
topic/gateway Topic gateway
Projects
None yet
Milestone
go-ipfs 0.9
Development

Successfully merging this pull request may close these issues.
2 participants
@lidel @Stebalien