chore: bump minimum go version to 1.15 #7944
Conversation
.circleci/config.yml
Outdated
| @@ -33,7 +33,7 @@ default_environment: &default_environment | |||
| executors: | |||
| golang: | |||
| docker: | |||
| - image: circleci/golang:1.14.4 | |||
| - image: circleci/golang:1.15.8 | |||
There was a problem hiding this comment.
It's a bit awkward that we track this here, below, and in the orb https://github.com/ipfs/ci-helpers/blob/fb84aaad053f46509acd7264420a57629ec95046/orbs/ci-go/%40root.yml#L26. Does this have to be duplicated?
There was a problem hiding this comment.
I think we only set it here to override the orb's default. We can update the one in the orb and delete this if you'd like.
There was a problem hiding this comment.
Looks like you may also want to change line 63 to have the same version of go.
At this point, probably want to update to test with go1.16.2
There was a problem hiding this comment.
I switched everything to 1.15.2 since that's what CircleCI gives us for the sharness containers and I figured it'd be good to keep all the testing aligned for now. We should figure out running tests for Go 1.15 and 1.16 (i.e. latest and latest-1)
| @@ -111,4 +111,4 @@ require ( | |||
| golang.org/x/sys v0.0.0-20210124154548-22da62e12c0c | |||
| ) | |||
|
|
|||
| go 1.14 | |||
| go 1.15 | |||
There was a problem hiding this comment.
There's no inherent reason we have to do this I guess, but given we're no longer testing with 1.14 this seems reasonable. WDYT @Stebalien?
|
And the readme. |
aschmahmann
force-pushed
the
chore/update-go-version
branch
from
246592f
to
1458215
Compare
|
Looks like the dockerfile also needs to be updated. |
aschmahmann
force-pushed
the
chore/update-go-version
branch
from
1458215
to
a81718f
Compare
bumping minimum version to 1.15 to indicate we are no longer explicitly supporting 1.14, and bumping CI testing to use 1.15.