Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commands/swarm(fix): handle empty multiaddrs #6355

Merged
merged 2 commits into from
May 20, 2019
Merged

commands/swarm(fix): handle empty multiaddrs #6355

merged 2 commits into from
May 20, 2019

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented May 20, 2019 •
edited
Loading

fixes #6354

@Stebalien
dep: update go-multiaddr
b892db8 
Forbids empty multiaddr, fixes #6354
michaelavila
michaelavila approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@michaelavila michaelavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stebalien Stebalien merged commit cf3b6c4 into master May 20, 2019
@Stebalien Stebalien deleted the fix/6354 branch May 20, 2019 22:47
@Stebalien Stebalien restored the fix/6354 branch May 30, 2019 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelavila michaelavila michaelavila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ipfs swarm connect → press enter → panic
2 participants
@Stebalien @michaelavila