Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only run the build test on test_go_expensive #4645

Merged
merged 1 commit into from
Feb 3, 2018
Merged

only run the build test on test_go_expensive #4645

merged 1 commit into from
Feb 3, 2018

Conversation

Stebalien
Copy link
Member

fixes #4642

@Stebalien
only run the build test on test_go_expensive
513b373 
fixes #4642

License: MIT
Signed-off-by: Steven Allen <[email protected]>
@ghost ghost assigned Stebalien Feb 3, 2018
@ghost ghost added the status/in-progress In progress label Feb 3, 2018
@Stebalien Stebalien requested a review from kevina February 3, 2018 12:32
Kubuxu
Kubuxu approved these changes Feb 3, 2018
View reviewed changes
Copy link
Member

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kevina
kevina approved these changes Feb 3, 2018
View reviewed changes
Copy link
Contributor

@kevina kevina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to add test_go_test under TESTING TARGETS (when you type just make) and explain what test_go_expensive does.

Otherwise, LGTM

@whyrusleeping whyrusleeping merged commit cb24cfa into master Feb 3, 2018
@whyrusleeping whyrusleeping deleted the fix/4642 branch February 3, 2018 23:24
@ghost ghost removed the status/in-progress In progress label Feb 3, 2018
@kevina kevina mentioned this pull request Feb 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevina kevina kevina approved these changes

@Kubuxu Kubuxu Kubuxu approved these changes

Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please don't run os builds as a part of the test_go_short
4 participants
@Stebalien @kevina @Kubuxu @whyrusleeping