fix loops in sharness tests to fail the test if the inner command fails #4482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
force-pushed
the
fix/fix-sharness-loops
branch
from
ea49e65 to
9c3af80
Compare
Stebalien
commented
Dec 13, 2017
| @@ -171,7 +171,6 @@ var rootROOldSubcommands = map[string]*oldcmds.Command{ | |||
| "links": ocmd.ObjectLinksCmd, | |||
| "get": ocmd.ObjectGetCmd, | |||
| "stat": ocmd.ObjectStatCmd, | |||
| "patch": ocmd.ObjectPatchCmd, | |||
Stebalien
added
the
status/blocked
Stebalien
commented
Dec 13, 2017
| @@ -139,11 +139,32 @@ test_expect_success "refs IPFS directory file through readonly API succeeds" ' | |||
| test_curl_gateway_api "refs?arg=$HASH2/test" | |||
| ' | |||
|
|
|||
| test_expect_success "test gateway api is sanitized" ' | |||
| for cmd in "add" "block/put" "bootstrap" "config" "dht" "diag" "dns" "get" "id" "mount" "name/publish" "object/put" "object/new" "object/patch" "pin" "ping" "refs/local" "repo" "resolve" "stats" "swarm" "file" "update" "version" "bitswap"; do | |||
| for cmd in add \ | |||
There was a problem hiding this comment.
I removed get, version, resolve, and dns as these are now exposed on the gateway.
|
You have angered the CI gods. You must now pay a penance |
|
@whyrusleeping that was intentional, these tests are now broken. |
|
@Stebalien don't break tests. Thats considered a bad thing. |
|
You could probably just delete the tests that are failing. |
|
@whyrusleeping the tests will be fixed after merging #4453. I opened this so I don't forget to fix them. I could have fixed them there but that PR keeps on changing and getting pushed back so I figured I'd reduce the noise and make a separate PR (blocked on it). |
This was hiding errors. License: MIT Signed-off-by: Steven Allen <[email protected]>
License: MIT Signed-off-by: Steven Allen <[email protected]>
This was discussed [here][1] but ignored. [1]: bfff3fa#r15654625 License: MIT Signed-off-by: Steven Allen <[email protected]>
Stebalien
force-pushed
the
fix/fix-sharness-loops
branch
from
9c3af80 to
958add6
Compare
Stebalien
removed
the
status/blocked
License: MIT Signed-off-by: Steven Allen <[email protected]>
We expect it to return a command error, not a 404, because `local` will be interpreted as a path. License: MIT Signed-off-by: Steven Allen <[email protected]>
|
Test failure was #4494 |
whyrusleeping
approved these changes
Dec 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was hiding errors.
Blocked on: #4453