add a test for auto-raising ulimit #2891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <[email protected]>
|
LGTM |
|
waiting for the travisCI OSX tests to go through... they are currently failing on master and its fixed in this PR |
| test_launch_ipfs_daemon | ||
|
|
||
| test_expect_success "daemon raised its fd limit" ' | ||
| grep "ulimit" actual_daemon > /dev/null |
There was a problem hiding this comment.
should have a way to check the number. this test does not test the thing in question, it only checks that a word exists in a message printed. Check the number it was raised to. if you can, verify that it was indeed raised with os cmds or something. or through some /debug api route
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Jeromy [email protected]