vendor libp2p with gx #2256

whyrusleeping · 2016-01-27T23:05:41Z

The biggest part of this PR will be making sure everything is still easy to dev with

rht · 2016-01-29T06:50:41Z

(this should take <=~O(1day) the longest)

daviddias · 2016-01-29T20:37:51Z

daviddias · 2016-01-29T20:39:19Z

Seal of Approval :D (//cc @RichardLitt)

whyrusleeping · 2016-01-29T20:41:42Z

i still need to fix the tests so they know what the hell is going on

License: MIT Signed-off-by: Jeromy <[email protected]>

whyrusleeping · 2016-02-01T06:15:25Z

now i'm running into docker issues... id like to copy $GOPATH/src/gx into the build context, but i dont see any easy way to do that. Its looking like i'll have to install gx on the docker image and run an install... which is annoying because i've already done it once during the CI test runs...

cc @lgierth

ghost · 2016-02-05T03:17:38Z

@whyrusleeping it's good now

whyrusleeping · 2016-02-05T05:07:51Z

oh my god look those tests are green o.o

whyrusleeping · 2016-02-05T05:08:48Z

@RichardLitt can you take a look at the usability here? Maybe help me out making the readme clear on how this works (all anyone should have to do is run make install)

whyrusleeping · 2016-02-05T05:09:20Z

i'll merge this in the morning, we can always improve the readme in a followup PR

chriscool · 2016-02-05T07:17:41Z

In the sharness tests some work has been done to remove any dependency on wget and to use curl instead. It would be nice here to use curl as much as possible instead of wget.

ghost · 2016-02-05T13:43:12Z

@chriscool wget is being used inside the container. I tried curl first but it doesn't have the retrying options I was looking for (retrying unconditionally).

rht · 2016-02-05T13:48:54Z

(in other situation, ipfs get/ipget was being used in place of curl since the latter doesn't do recursive download (while wget does) )

RichardLitt · 2016-02-05T15:40:15Z

@whyrusleeping I opened github.com//pull/2302 to merge into this branch. Is that what you wanted?

I did the following: - Capitalized IPFS wherever it did not explicitely refer to the CLI command - Moved Dev Dependencies into the Install section - Added a Table of Contents - Capitalised and added periods to various sentences - Capitalised Go - Removed double empty lines - Reindented a few sections to make the flow more clear. - Added a note to the Install section about how to canonically install. License: MIT Signed-off-by: Richard Littauer <[email protected]>

Cleaned up README

hackergrrl · 2016-02-05T22:45:34Z

assets/assets_test.go

@@ -9,10 +9,12 @@ import (

 // TestEmbeddedDocs makes sure we don't forget to regenerate after documentation change
 func TestEmbeddedDocs(t *testing.T) {
+	t.Skip("skipping for now, paths are hard")


I'm not really familiar with assets/: what is this test supposed to do and why are we now skipping it? Could we get a tracking issue and link to it here so it doesn't fall entirely off the radar?

the test is testing that the string constants in this file match the files stored in git. Except now those files are stored in gx (and we arent storing the gx deps in git). I can probably add a bit of logic to search for the installed package either locally or globally. Good catch

hackergrrl · 2016-02-05T23:24:53Z

Nice work @whyrusleeping. It's been cool watching gx go from proof of concept to powering go-ipfs.

Some usability feedback:

make in cmd/ipfs/ doesn't work: gx looks for package.json, which of course is back in the root directory.
make is now very expensive. Every invocation does go get -u gx, go get -u gx-go, and gx install, even when you're up to date. This makes my builds internet dependent, and significantly slower -- adds ~43 seconds. Other folks might have different workflows, but I rely on make for development; I'd be really keen on keeping it fast. Maybe having dummy files we touch on go get and gx install would work well with make?
More makefile stuff: right now only install depends on deps, but I think build targets should rely on deps instead -- and then we can have install rely on build. Does that make sense?

Kudos @RichardLitt for the nice clean-up to the README; it's an entry point for so many people who look at IPFS. 👍

whyrusleeping · 2016-02-05T23:49:04Z

@noffle good catch on the cmd/ipfs makefile, missed that one. As for make being expensive, I do want to ensure that anyone building ipfs as per the listed build instructions has their deps up to date. Building without the makefile is quite easy: go install ./cmd/ipfs or go build ./cmd/ipfs. We could have a make fast-install or make fast-build type target for your usecase if you don't want to type the go commands.

having install depend on build depend on deps is a good idea. changing that now.

License: MIT Signed-off-by: Jeromy <[email protected]>

hackergrrl · 2016-02-06T00:03:19Z

As for make being expensive, I do want to ensure that anyone building ipfs as per the listed build instructions has their deps up to date.

Agreed. Ideally we'd have versions of gx and gx-go pinned so we could skip these heavy steps. I'll think about the problem some more, but yeah: it doesn't make sense to hold up this PR because of it.

hackergrrl · 2016-02-06T00:06:32Z

🐴 LGTM

vendor libp2p with gx

rht · 2016-02-06T07:07:31Z

Somehow missed the go get -u in the make install. This breaks the immutability of the build of go-ipfs of a specific commit (with gx remains as being mutable).

hackergrrl · 2016-02-06T19:47:59Z

@rht: yeah +1. I'd like to see a means of retrieving a pinned version of gx and gx-go as well. Maybe via ipget or just wgeting the public gateway?

rht · 2016-02-07T01:56:54Z

It is simplest to just bootstrap gx, gx-go in vendor/ (this is the closest thing to hash/version pinning in go anyway, albeit implicit). That way, the deps that are fetched by gx are still pinned by their hashes or versions from package.json.

This was referenced Jan 29, 2016

Yank gateway out to a separate repo #2006

Closed

Leave overflow logic to go-msgio #1910

Closed

whyrusleeping added 10 commits January 30, 2016 09:34

initial vendoring of libp2p outside of the repo with gx

0e312f5

License: MIT Signed-off-by: Jeromy <[email protected]>

package.json cleanup

e12a56d

License: MIT Signed-off-by: Jeromy <[email protected]>

add makefile rule for grabbing gx and deps

3b784b5

License: MIT Signed-off-by: Jeromy <[email protected]>

go-keyspace dep from libp2p added

3d0aa59

License: MIT Signed-off-by: Jeromy <[email protected]>

correct go-log dep

0e8a670

License: MIT Signed-off-by: Jeromy <[email protected]>

add better makefile and reference gx stuff in readme

0dba051

License: MIT Signed-off-by: Jeromy <[email protected]>

go go circle tests!

1f1c52c

License: MIT Signed-off-by: Jeromy <[email protected]>

circle.yml fix?

b16c0ce

License: MIT Signed-off-by: Jeromy <[email protected]>

verbose gx install

9c05a0d

License: MIT Signed-off-by: Jeromy <[email protected]>

gx install stuff in cmd/ipfs/Makefile

b5a93ea

License: MIT Signed-off-by: Jeromy <[email protected]>

whyrusleeping force-pushed the feat/gx-libp2p branch from e774205 to b5a93ea Compare January 30, 2016 17:34

whyrusleeping added 12 commits January 30, 2016 10:37

circleci verbose

b96c2e6

License: MIT Signed-off-by: Jeromy <[email protected]>

travis file change

d141589

License: MIT Signed-off-by: Jeromy <[email protected]>

circleci fun fun fun

1b6e426

License: MIT Signed-off-by: Jeromy <[email protected]>

i'm beginning to dislike circleci

bf3ad94

License: MIT Signed-off-by: Jeromy <[email protected]>

on a scale from 1 to annoying, i don't like circleCI anymore at all

ed3841f

License: MIT Signed-off-by: Jeromy <[email protected]>

ciiiii issss awesome

89bb338

License: MIT Signed-off-by: Jeromy <[email protected]>

circleci has bad documentation

57c6e1e

License: MIT Signed-off-by: Jeromy <[email protected]>

lets not have any documentation for this stupid file format, its awesome

49ae649

License: MIT Signed-off-by: Jeromy <[email protected]>

also, yaml is a terrible format

c900a1e

License: MIT Signed-off-by: Jeromy <[email protected]>

documentation saves lives

4012c6b

License: MIT Signed-off-by: Jeromy <[email protected]>

update libp2p dep

c0101c0

License: MIT Signed-off-by: Jeromy <[email protected]>

do that last thing again

2263539

License: MIT Signed-off-by: Jeromy <[email protected]>

ghost mentioned this pull request Feb 5, 2016

Docker Run: ERR: /data/ipfs is not writable for user 'ipfs' (UID 1000) #2245

Closed

RichardLitt and others added 2 commits February 5, 2016 11:08

Merge pull request #2302 from ipfs/feature/gx-libp2p-readme-edits

ffc4831

Cleaned up README

hackergrrl reviewed Feb 5, 2016
View reviewed changes

whyrusleeping added 3 commits February 5, 2016 15:50

makefile fixes

c9b83c5

License: MIT Signed-off-by: Jeromy <[email protected]>

note in assets test

5c5ad7a

License: MIT Signed-off-by: Jeromy <[email protected]>

add deps target to nofuse

3373138

License: MIT Signed-off-by: Jeromy <[email protected]>

whyrusleeping added a commit that referenced this pull request Feb 6, 2016

Merge pull request #2256 from ipfs/feat/gx-libp2p

5a0b802

vendor libp2p with gx

whyrusleeping merged commit 5a0b802 into master Feb 6, 2016

whyrusleeping deleted the feat/gx-libp2p branch February 6, 2016 00:52

RichardLitt mentioned this pull request Feb 6, 2016

IPFS Weekly Updates ipfs/ipfs#151

Closed

hackergrrl mentioned this pull request Feb 8, 2016

Sprint: February 1 ipfs/team-mgmt#88

Closed

Kubuxu mentioned this pull request Jun 24, 2016

Add option for datastore read rehashing #2904

Merged

olizilla mentioned this pull request Sep 4, 2019

Docker built go-ipfs fails to report its commit version #6622

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vendor libp2p with gx #2256

vendor libp2p with gx #2256

whyrusleeping commented Jan 27, 2016

rht commented Jan 29, 2016

daviddias commented Jan 29, 2016

daviddias commented Jan 29, 2016

whyrusleeping commented Jan 29, 2016

whyrusleeping commented Feb 1, 2016

ghost commented Feb 5, 2016

whyrusleeping commented Feb 5, 2016

whyrusleeping commented Feb 5, 2016

whyrusleeping commented Feb 5, 2016

chriscool commented Feb 5, 2016

ghost commented Feb 5, 2016

rht commented Feb 5, 2016

RichardLitt commented Feb 5, 2016

hackergrrl Feb 5, 2016

whyrusleeping Feb 5, 2016

hackergrrl commented Feb 5, 2016

whyrusleeping commented Feb 5, 2016

hackergrrl commented Feb 6, 2016

hackergrrl commented Feb 6, 2016

rht commented Feb 6, 2016

hackergrrl commented Feb 6, 2016

rht commented Feb 7, 2016

vendor libp2p with gx #2256

vendor libp2p with gx #2256

Conversation

whyrusleeping commented Jan 27, 2016

rht commented Jan 29, 2016

daviddias commented Jan 29, 2016

daviddias commented Jan 29, 2016

whyrusleeping commented Jan 29, 2016

whyrusleeping commented Feb 1, 2016

ghost commented Feb 5, 2016

whyrusleeping commented Feb 5, 2016

whyrusleeping commented Feb 5, 2016

whyrusleeping commented Feb 5, 2016

chriscool commented Feb 5, 2016

ghost commented Feb 5, 2016

rht commented Feb 5, 2016

RichardLitt commented Feb 5, 2016

hackergrrl Feb 5, 2016

Choose a reason for hiding this comment

whyrusleeping Feb 5, 2016

Choose a reason for hiding this comment

hackergrrl commented Feb 5, 2016

whyrusleeping commented Feb 5, 2016

hackergrrl commented Feb 6, 2016

hackergrrl commented Feb 6, 2016

rht commented Feb 6, 2016

hackergrrl commented Feb 6, 2016

rht commented Feb 7, 2016