Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Handle context cancellation. #16

Merged
merged 5 commits into from
May 24, 2022
Merged

Conversation

ajnavarro
Copy link
Member

@ajnavarro ajnavarro commented May 19, 2022

It closes #15

Signed-off-by: Antonio Navarro Perez [email protected]

@welcome
Copy link

welcome bot commented May 19, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@ajnavarro ajnavarro requested review from petar and guseggert May 19, 2022 13:51
@ajnavarro ajnavarro self-assigned this May 19, 2022
@ajnavarro ajnavarro added this to the go-ipfs 0.14 milestone May 19, 2022
Copy link
Contributor

@petar petar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few comments and clarifications. Thanks!

client/findproviders.go Outdated Show resolved Hide resolved
client/findproviders.go Outdated Show resolved Hide resolved
client/getipns.go Outdated Show resolved Hide resolved
client/getipns.go Outdated Show resolved Hide resolved
client/getipns.go Outdated Show resolved Hide resolved
client/getipns.go Outdated Show resolved Hide resolved
client/getipns.go Outdated Show resolved Hide resolved
client/putipns.go Outdated Show resolved Hide resolved
@ajnavarro ajnavarro force-pushed the fix/cancel-contexts branch from ff4c0c6 to 3028c89 Compare May 20, 2022 07:39
@ajnavarro
Copy link
Member Author

It depends on ipld/edelweiss#34 to pass the tests.

@ajnavarro ajnavarro force-pushed the fix/cancel-contexts branch 2 times, most recently from e5bd04d to e5c3ed4 Compare May 23, 2022 08:29
@ajnavarro ajnavarro force-pushed the fix/cancel-contexts branch from e5c3ed4 to 5606400 Compare May 23, 2022 08:31
@ajnavarro ajnavarro requested a review from petar May 23, 2022 08:42
client/findproviders.go Outdated Show resolved Hide resolved
client/getipns.go Outdated Show resolved Hide resolved
client/getipns.go Outdated Show resolved Hide resolved
client/putipns.go Outdated Show resolved Hide resolved
@ajnavarro ajnavarro requested a review from petar May 24, 2022 13:39
Copy link
Contributor

@petar petar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ajnavarro ajnavarro merged commit 968b113 into ipfs:main May 24, 2022
@ajnavarro ajnavarro deleted the fix/cancel-contexts branch May 24, 2022 16:36
ajnavarro added a commit to ipfs/boxo that referenced this pull request Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

synchronized context cancellation with writing to result channel
2 participants