Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for _redirects with If-None-Match headers #111

Closed
lidel opened this issue Jul 19, 2023 · 0 comments · Fixed by #160
Closed

Add test for _redirects with If-None-Match headers #111

lidel opened this issue Jul 19, 2023 · 0 comments · Fixed by #160
Labels
test:coverage Improves the spec covered by this test suite

Comments

@lidel
Copy link
Member

lidel commented Jul 19, 2023 •
edited
Loading

We need a regression test for ipfs/boxo#412

iiuc it should have _redirects

# Map SPA routes to the main index HTML file.
/* /index.html 200

and make request for /ipfs/cid/MISSING-PAGE twice, second time sending If-None-Matc with Etag value from the first response.

There is a test already on the linked PR, and aCAR fixture which we should reuse as-is:
Ref. https://github.com/ipfs/boxo/pull/412/files#diff-d34c7069ce5e81d45082b19eb3e869ee1a086e185dcd6630e75e3ed0d368b546
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test:coverage Improves the spec covered by this test suite
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: percent-encoded filename and _redirects with If-None-Match on DNSLink ipfs/gateway-conformance
2 participants
@lidel @laurentsenta