Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-final-launch fit and finish #186

Closed
17 tasks done
jessicaschilling opened this issue Jul 13, 2021 · 10 comments · Fixed by #190
Closed
17 tasks done

Pre-final-launch fit and finish #186

jessicaschilling opened this issue Jul 13, 2021 · 10 comments · Fixed by #190
Assignees
Labels
dif/medium Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@jessicaschilling
Copy link
Contributor

jessicaschilling commented Jul 13, 2021

This issue is for collecting visual or minor functional items that need to be resolved before final launch. Please edit this comment to add any new items. Please open separate issues for larger items.

Site-wide

  • Breadcrumbs should appear at the same distance from top of the page across all pages of the site at all viewport widths; please use the blog placement (at the top of the pile) as a source of truth:
    image
  • Implement accessibility #200

Front page

  • This seems like a new issue, but the segment chart is blowing out on narrow mobile (this is 320px wide):
    image
  • Also as referenced in the above screenshot - what would you think about putting a subtle border or shadow around the Filters button so it doesn't feel like an overlay mistake? I think what's nudging me is areas when it appears white-on-white, so just looks like floating text. I'm sure @D3AS8A has thoughts 😊
  • At mobile widths in particular, the margins around the showcase slider make it difficult to tell what the slider actually impacts. Can we please tighten those up?
    image
  • Am also seeing some strange behavior on resize for the "All projects" header area in general - resulting in margins being huge or occasionally the content sometime disappearing ... I think this has to do with the viewport height just based on behavior, but not sure:
    image
  • For null filter results, I know we have the "Clear (x) Selected" item, but would it be possible as well to add a text link in the results area, e.g. "No results found that match the selected filters. Clear all"?
    image
  • Can the logic for keeping the Filters button out of the footer also extend to content below the footer when the page itself is short on content? Example below. Ignore if this sends you down a massive rabbit hole, please!
    image
  • At super-wide widths, the white space on the left of the filter panel looks odd. @D3AS8A probably has a better idea than me for a fix, but it could just be a matter of making the filter panel background start at the main page body's left margin: animation-wise, the effect would be of the filter panel sliding out rather than expanding out.
    image
  • If someone clicks on "All projects" in the breadcrumb, they're taken to the "All projects" page with the filter panel open. That's awesome at desktop widths, but at widths narrow enough for the filter panel to take over the whole screen, it's a little jarring. Would it make sense to only expand the filter panel on load for viewports over a certain width?
    image

Project pages

  • Can the collapse arrows please be vertically centered on the headers they correspond to?
    image

  • Vertical margins overall on the "Featured projects" section are a little large, particularly at mobile widths:
    image
    image

  • Additionally, for super-wide widths, can you please make the "Featured projects" section no wider than the main body content width?
    image

  • Big-number boxes and CTAs are a little awkward at mobile widths. Can we please have big-number labels (e.g. "Content identifiers") pack from the top rather than the bottom, and increase the font size of the CTA title (e.g. "Audius case study") - or probably just not decrease it from its previous size?
    image
    image

  • For viewport widths where the big numbers/CTAs stack, can the project description please span the full width of the viewport?
    image

  • Don't want to override @D3AS8A if she has strong feels on this one, but I've seen folks miss the primary CTA button for "Project website" in cases where there's also a button in the cards (big number/CTA) section. I think the outline style is tripping them up and wonder if it'd be better to use the same primary button style as on the blog/IPFS website (i.e. the style in the "Subscribe" button in the footer)?
    image

  • For truncated content in the "Key info" section, the question mark hover is a little weird - honestly I think this was an artifact in an earlier wireframe that escaped deletion. Could we please just remove the question mark icon entirely and invoke the hover text by hovering on the truncated text, like on the front page?
    image

@jessicaschilling jessicaschilling added need/triage Needs initial labeling and prioritization dif/medium Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked and removed need/triage Needs initial labeling and prioritization labels Jul 13, 2021
@timelytree
Copy link
Collaborator

At mobile widths in particular, the margins around the showcase slider make it difficult to tell what the slider actually impacts. Can we please tighten those up?

@jessicaschilling this is a bit of a tough one. I managed to tighten it up by 2 rems but the main issue stems from the fact that the slider contains cards with unequal amounts of card title/description text. Because the slider takes the height of the largest card, in some cases when there's less text, it ends up looking like there's just randomly more space *tear (screenshots below)

This is fixable by giving the slider an adaptive height but also would possibly be worse UX because then the slider control would move up/down as the slider re-adjusts height, often moving from under one's finger on mobile. I would make the suggestion to instead select projects to feature that all have equal (or almost equal) amounts of text → or to add more text to the currently featured projects. So ultimately fix by tweaking copy rather than functionality.

What do you think @jessicaschilling? 🙂

one-liners
Screen Shot 2021-07-15 at 11 01 30

two-liners
Screen Shot 2021-07-15 at 11 03 34

@jessicaschilling
Copy link
Contributor Author

@timelytree oh, right - that totally makes sense. Can definitely tweak content, I think your approach makes the most sense. And in any case, the 2rem helps a lot 😊

@orvn orvn linked a pull request Jul 20, 2021 that will close this issue
@timelytree
Copy link
Collaborator

@jessicaschilling for this item:

At super-wide widths, the white space on the left of the filter panel looks odd. @D3AS8A probably has a better idea than me for a fix, but it could just be a matter of making the filter panel background start at the main page body's left margin: animation-wise, the effect would be of the filter panel sliding out rather than expanding out.

Can you elaborate on this part:

filter panel sliding out rather than expanding out

Also looks-wise we had the idea of making the white fade rather than go forever, what do you think? 🙂

Screen Shot 2021-07-23 at 09 44 17

@jessicaschilling
Copy link
Contributor Author

The fade works! And negates my "sliding out" comment, so feel free to ignore that.

@D3AS8A
Copy link
Collaborator

D3AS8A commented Jul 23, 2021

* Don't want to override @D3AS8A if she has strong feels on this one, but I've seen folks miss the primary CTA button for "Project website" in cases where there's also a button in the cards (big number/CTA) section. I think the outline style is tripping them up and wonder if it'd be better to use the same primary button style as on the blog/IPFS website (i.e. the style in the "Subscribe" button in the footer)?

@jessicaschilling

Thanks for flagging this. See image below of proposed solution to reorient users attention to primary CTA (on left). Initially I placed the case study as primary and project site as secondary.

Screen Shot 2021-07-23 at 2 29 44 PM

Notes for @timelytree

  • box border to #F1F3F2
  • in box cta button inverse, filled on hover (button height increased to 40px)
  • see other values in XD file

@jessicaschilling
Copy link
Contributor Author

@D3AS8A Looks good, thanks!

@timelytree
Copy link
Collaborator

@jessicaschilling I hope you don't mind → I moved the 2nd item in the list (regarding accessibility) into its own Issue (#200) as it's sort of its own thing that we're going to tackle (starting with tabbing through the nav). We'll populate the Issue with more details soon! 🙂

@timelytree
Copy link
Collaborator

timelytree commented Aug 10, 2021

Hey @jessicaschilling 👋🏼 I just wanted to outline the list of items that we have left on the docket. I don't think any of these are showstoppers for a hard launch but I'll let you tell me otherwise 😅

  • SEO → already complete and live, just adding some extras and doing an audit, scheduled for this week
  • Accessibility → mostly complete and live, currently underway, scheduled for this week
  • Clean up and abstract nuxt-module-ipfs → currently underway, scheduled for next week
  • Abstract out Shipyard → currently underway, scheduled for next week
  • Embeddable view → already complete but not live, just making final very minor design tweaks, scheduled for this week
  • Greatly expand settings → complete and awaiting review/merging, scheduled for this week

@jessicaschilling
Copy link
Contributor Author

Awesome, thanks @timelytree! I think we're in a good place to start promoting this more widely. I've asked the marketing team to get it added to their list of "evergreen" social promo items, and will get a blog post in the works announcing the directory.

@jessicaschilling
Copy link
Contributor Author

For anyone who's following along at home: work in the depersonalized boilerplate repo is happening at https://github.com/ipfs-shipyard/ecosystem-directory 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dif/medium Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants