-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter panel chiclets should be "or", not "and" #165
Comments
@D3AS8A, thoughts on this for something to address in the pre-public-launch queue? |
Re: “or” vs “and” in filtter panel tag selection, we’ve huddled about this before and the determination at the time was that there would be instances of projects that could technically fit into multiple categories. I imagine the current implementation would feel more intuitive as this ecosystem grows (with a larger sample size to work from).
|
@D3AS8A Completely agree about this making more sense for larger sample sets, but also understand that for a 65-instance set of projects that @thattommyhall's comment makes sense as well. If we have the ability to offer a config setting to choose between and/or on a per-repo basis without going out of scope, that would be great ... but if we only have one option, given that we suspect we'll be seeing a significant number of small-scale forks of this (for hackathons in particular), it might be better to use "or" rather than "and". |
Should be okay, but let me make sure that there isn't anything else that might need to be considered (incl. different messaging that allows the user to infer what the filters are doing) |
Adding this option as a feature in settings. |
Pushed to production, with settings for:
"tagMatchType": "or",
"excludeFilterAllTag": false (these settings can be found in |
Relayed from @thattommyhall: Filter panel chiclet doesn't do what's expected upon multi-selection — "in my head you are filtering for any of N industries, not each of N".
Indeed, this is an expected e-commerce pattern — example from Amazon:

Regardless of final approach to "or" vs "and", let's consider the following:
The text was updated successfully, but these errors were encountered: