Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter panel chiclets should be "or", not "and" #165

Closed
jessicaschilling opened this issue Jun 28, 2021 · 6 comments · Fixed by #187
Closed

Filter panel chiclets should be "or", not "and" #165

jessicaschilling opened this issue Jun 28, 2021 · 6 comments · Fixed by #187
Assignees
Labels
dif/medium Prior experience is likely helpful effort/hours Estimated to take one or several hours kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up

Comments

@jessicaschilling
Copy link
Contributor

Relayed from @thattommyhall: Filter panel chiclet doesn't do what's expected upon multi-selection — "in my head you are filtering for any of N industries, not each of N".

Indeed, this is an expected e-commerce pattern — example from Amazon:
image

Regardless of final approach to "or" vs "and", let's consider the following:

  • Remove "All" as it's pretty much guaranteed to get you to null results
  • Consider replacing it with "Clear selection" in order to clear selection per filter category (more granular than just the "Clear x selected" at bottom of filter panel)
@jessicaschilling jessicaschilling added the need/triage Needs initial labeling and prioritization label Jun 28, 2021
@jessicaschilling jessicaschilling added dif/medium Prior experience is likely helpful effort/hours Estimated to take one or several hours kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up and removed need/triage Needs initial labeling and prioritization labels Jun 28, 2021
@jessicaschilling
Copy link
Contributor Author

@D3AS8A, thoughts on this for something to address in the pre-public-launch queue?

@D3AS8A
Copy link
Collaborator

D3AS8A commented Jun 30, 2021

@jessicaschilling

Re: “or” vs “and” in filtter panel tag selection, we’ve huddled about this before and the determination at the time was that there would be instances of projects that could technically fit into multiple categories.

I imagine the current implementation would feel more intuitive as this ecosystem grows (with a larger sample size to work from).

Right now, every category in the taxonomy is designed as an array—tags are inherently not mutually exclusive. The current implementation was meant to act as a type of drill down— allowing the user to start with a broad search and then refine to a narrow search as desired.

  • All serves as quick multi-chiclet selection option we use to address behavioral patterns seen with technically proficient where users click all and then deselect only one item, in the interest of time.

  • What do you think of following the current information scent and keeping in clean by adding a “clear filters” option right where the “of “ appears? See image.

clear selected filters

@jessicaschilling
Copy link
Contributor Author

@D3AS8A Completely agree about this making more sense for larger sample sets, but also understand that for a 65-instance set of projects that @thattommyhall's comment makes sense as well.

If we have the ability to offer a config setting to choose between and/or on a per-repo basis without going out of scope, that would be great ... but if we only have one option, given that we suspect we'll be seeing a significant number of small-scale forks of this (for hackathons in particular), it might be better to use "or" rather than "and".

@orvn
Copy link
Collaborator

orvn commented Jul 6, 2021

If we have the ability to offer a config setting to choose between and/or on a per-repo basis without going out of scope

Should be okay, but let me make sure that there isn't anything else that might need to be considered (incl. different messaging that allows the user to infer what the filters are doing)

@orvn orvn assigned orvn and unassigned D3AS8A Jul 13, 2021
@orvn
Copy link
Collaborator

orvn commented Jul 13, 2021

Adding this option as a feature in settings.

@orvn orvn linked a pull request Jul 14, 2021 that will close this issue
@orvn orvn closed this as completed in #187 Jul 14, 2021
@orvn
Copy link
Collaborator

orvn commented Jul 14, 2021

Pushed to production, with settings for:

  1. Toggling behavior of selected tags between or and and
  2. Hiding the All multi-tag selector in front of categories in the filters panel
        "tagMatchType": "or",
        "excludeFilterAllTag": false

(these settings can be found in settings.json)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dif/medium Prior experience is likely helpful effort/hours Estimated to take one or several hours kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants