Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert custom footer into snapshots #17

Closed
flyingzumwalt opened this issue May 6, 2017 · 4 comments
Closed

Insert custom footer into snapshots #17

flyingzumwalt opened this issue May 6, 2017 · 4 comments
Assignees

Comments

@flyingzumwalt
Copy link
Contributor

flyingzumwalt commented May 6, 2017

Make a body.js file in this repo that inserts our footer instead of the original social media links. When we build wikipedia snapshots we will replace the original body.js with this new body.js so the footer includes a clear statement about who generated the snapshots. (see #13)

Add the new file to #16

@Kubuxu
Copy link
Member

Kubuxu commented May 6, 2017

Is having this content in articles OK: This article is issued from Vikipedi - version of the 1/11/2017. The text is available under the Creative Commons Attribution/Share Alike but additional terms may apply for the media files.?

If not we have to rewrite the articles either way.

@flyingzumwalt
Copy link
Contributor Author

Yes. It's ok to have that content in the articles as long as we have the additional info in our footer immediately below it saying who generated and disseminated the snapshot.

@victorb
Copy link
Member

victorb commented May 6, 2017

Added body.js that will add our footer. This file will need to have the variables inside it replaced before adding to IPFS.

Added a demo as well, to make sure it works. If you add that whole directory to IPFS and go to /out/A/Anasayfa.html, the correct footer should be rendered.

➜  distributed-wikipedia git:(feat/footer) tree demo 
demo
├── out
│   ├── -
│   │   └── j
│   │       └── body.js
│   └── A
│       └── Anasayfa.html
└── wikipedia-on-ipfs.png

Looks like this:

image

@flyingzumwalt
Copy link
Contributor Author

Thanks @victorbjelkholm! I added the "This snapshot was generated and distributed by..." line back into the body.js. Now we're good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants