fix: remove no-bundle from test build and fix flag #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We run build before test but pass `--no-bundle` on the assumption that a project build command is `aegir build`. Passing `--no-bundle` skips making a minified build for a tiny speedup. If the project build command isn't `aegir build` this can break things so remove the optimisation. Also build by default before test and fix the problem whereby the build flag was being ignored for typescript projects. Fixes: #975
SgtPooki
approved these changes
Jun 27, 2022
|
🎉 This PR is included in version 37.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run build before test but pass
--no-bundleon the assumption that a project build command isaegir build. Passing--no-bundleskips making a minified build for a tiny speedup.If the project build command isn't
aegir buildthis can break things so remove the optimisation.Also build by default before test (to support typescript) and fix the problem whereby the build flag was being ignored for typescript projects.
Fixes: #975