Update to async iterators #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs `ipfs.id` to return a `CID` before tests will pass.
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
========================================
Coverage ? 89.4%
========================================
Files ? 6
Lines ? 151
Branches ? 0
========================================
Hits ? 135
Misses ? 16
Partials ? 0
Continue to review full report at Codecov.
|
This was referenced Jan 24, 2020
alanshaw
pushed a commit
to ipfs/js-ipfs
that referenced
this pull request
Feb 10, 2020
It does not depend on IPFS or the HTTP client. https://github.com/ipfs-shipyard/ipfs-pubsub-room Looks like this was a recent change ipfs-shipyard/ipfs-pubsub-room#73
alanshaw
pushed a commit
to ipfs/js-ipfs
that referenced
this pull request
Feb 10, 2020
It does not depend on IPFS or the HTTP client. https://github.com/ipfs-shipyard/ipfs-pubsub-room Looks like this was a recent change ipfs-shipyard/ipfs-pubsub-room#73
alanshaw
pushed a commit
to ipfs/js-ipfs
that referenced
this pull request
Feb 11, 2020
It does not depend on IPFS or the HTTP client. https://github.com/ipfs-shipyard/ipfs-pubsub-room Looks like this was a recent change ipfs-shipyard/ipfs-pubsub-room#73
davideicardi
pushed a commit
to davideicardi/js-ipfs
that referenced
this pull request
Feb 11, 2020
It does not depend on IPFS or the HTTP client. https://github.com/ipfs-shipyard/ipfs-pubsub-room Looks like this was a recent change ipfs-shipyard/ipfs-pubsub-room#73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs
ipfs.idto return aCIDbefore tests will pass.