-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Count with all sorts of contributions #8
Comments
Got it, @RichardLitt went for all contributors on repos (code contributors) -- https://github.com/ipfs/get-gh-contributors/blob/master/src/fetch.js#L37 -- while you went to a more board definition of a contributor. Makes sense to me :) I'm not sure if it was a decision at the time to only check code commiters, but new version looks better. woot! |
We previously talked about counting people filing issues and commenting on issues as contributors too, which is the approach i took |
Yep. That was the approach for name-your-contributors. This code merely got the contributors as defined by GitHub, most likely due to time constraints. But what you outline above is more inclusive, and therefore, IMHO, better. 👍 |
https://github.com/RichardLitt/name-your-contributors works now. Might be worth looking into and using for this. |
@ipfs/dx team, Can I ask for your help to get this get-gh-contributors running so that we get the latest head count? |
@diasdavid seems name-your-contributors (by RichardLitt) mentioned above would do the same thing as the program whyrusleeping suggested, could we just use that? What's the ask here, to have it running with API endpoints rather than as a CLI? |
@victorbjelkholm I need the dataset -- https://github.com/ipfs/contributors-hex-grid/blob/master/public-vertical/js/contributors.js -- to be up to date. I'm fine with either tool, as long as it is accurate. |
Well, name-your-contributors is to my knowledge accurate. It should work for this. @victorbjelkholm let me know if you need help. |
Note to self. The go program expects a |
@RichardLitt name-your-contributors is looking rad! It is just unfortunate that it currently fails for orgs mntnr/name-your-contributors#72 |
Just finished running the script and learned that something has changed because I'm no longer getting 3000 +++ like last time, just 2441 for this round. Trying to find the time to figure this one out. Update: found the issue, it was just picking up on 10 repos from each org. Increased that now. Need to crawl the rest. |
|
@daviddias Sorry that it fails! Did you get it working? I've been slammed the past couple of days. |
Not sure whats wrong exactly, but the code in this repo doesnt produce the right output (its missing a lot of people).
Heres the go code i wrote that seems to be correct:
The text was updated successfully, but these errors were encountered: