-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add comment-placer-component #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PedroMiguelSS
force-pushed
the
feat/comment-placer-component
branch
from
February 1, 2019 12:52
ee94d85
to
654e9b3
Compare
This was referenced Feb 3, 2019
satazor
suggested changes
Feb 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think we are missing a README.md file and storybook entry for the CommentPlacer.
src/components/comment-placer/fade-transition/FadeTransition.js
Outdated
Show resolved
Hide resolved
satazor
suggested changes
Feb 21, 2019
src/components/comment-placer/fade-and-grow-transition/FadeAndGrowTransition.js
Outdated
Show resolved
Hide resolved
src/components/comment-placer/fade-transition/FadeTransition.js
Outdated
Show resolved
Hide resolved
satazor
force-pushed
the
feat/comment-placer-component
branch
from
February 21, 2019 17:32
9fa1521
to
22f1c01
Compare
satazor
force-pushed
the
feat/comment-placer-component
branch
from
February 21, 2019 17:34
22f1c01
to
e921613
Compare
There's a bug in the textarea height animation in some situations but @acostalima will take care of it later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
CommentPlacer
component. The main goal of this component is to sync animations, scroll and automatic focus that may happen simultaneously.It handles entry animations for comments. We have currently 2 different animations:
FadeAndGrow
andFade
. They are used in different cases:FadeAndGrow
is applied whether a new comment or a reply textarea enters on the list.Fade
is used when an edit textarea appears.Sync flows
FadeAndGrow
entry animation occurs (if the comment will be visible) -> scroll to new comment (if I'm the author of the comment)FadeAndGrow
entry animation occurs (if the textarea will be visible) -> scroll to the element occurs -> automatic focus happensFade
entry animation occurs to make textarea visible -> automatic focus happensnew reply
-> focus is disabled ->Fade
exiting animation occurs to unmount textarea and make the new comment visible.new reply
-> focus is disabled ->FadeAndGrow
exiting animation occurs.edit comment
-> focus is disabled ->Fade
exiting animation occurs to unmount textarea and make the old comment visible.edit comment
-> focus is disabled ->Fade
exiting animation occurs to unmount textarea and make the edited comment visible.This component also takes care of another animation: scale comments when they come into view (while users are scrolling the list). Kind of a skew effect.
Other components on this PR
FadeAndGrowTransition
FadeTransition
FocusManager