Skip to content
This repository has been archived by the owner on Apr 29, 2020. It is now read-only.

Added Group pin #48

Merged
merged 6 commits into from
Apr 13, 2016
Merged

Added Group pin #48

merged 6 commits into from
Apr 13, 2016

Conversation

RichardLitt
Copy link
Contributor

I am not sure about ls count. I do not think that ls --quiet is an argument: the go code is a flag for Fprintf or not, which makes me think it does not affect the API returns. But I cannot tell, because in Wireshark it is all sent as flags.


## ls
## add [GET /pin/add{?arg}{&recursive}]
Pins objects to local storage
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing .

I am not sure about ls count. I do not think that ls --quiet is an argument: the go code is a flag for Fprintf or not, which makes me think it does not affect the API returns. But I cannot tell, because in Wireshark it is all sent as flags.
@RichardLitt
Copy link
Contributor Author

@whyrusleeping Note @dignifiedquire's comments in the outdated diffs. Some of the flags don't seem to work on the API.

@RichardLitt
Copy link
Contributor Author

Before merging, this needs to be updated to reflect changes in https://github.com/ipfs/go-ipfs/pull/2477/files.

@daviddias
Copy link
Contributor

@RichardLitt ipfs/kubo#2477 was merged. Can we merge this one now?

@RichardLitt RichardLitt merged commit e702e18 into master Apr 13, 2016
@RichardLitt RichardLitt deleted the feature/pin branch April 13, 2016 13:52
@RichardLitt
Copy link
Contributor Author

Merged!

@daviddias
Copy link
Contributor

wooo :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants