Skip to content
This repository has been archived by the owner on Apr 29, 2020. It is now read-only.

Added Group object #32

Closed
wants to merge 9 commits into from
Closed

Added Group object #32

wants to merge 9 commits into from

Conversation

RichardLitt
Copy link
Contributor

No description provided.

@RichardLitt RichardLitt changed the title [WIP] Add Group object Add Group object Feb 4, 2016
@RichardLitt
Copy link
Contributor Author

Questions

These need to be answered and dealt with before merge:

  • I can't figure out how to get object patch to work in curl.
  • There are seemingly arbitrary differences in error messages that respond as a string, and those which respond with a JSON object with Message and Code. CF Error Messages: What does Code mean?  ipfs/kubo#2293
  • protobuf doesn't work as an encoding sometimes. The usage seems arbitrary and inconsistent.
  • xml isn't specified as a possible encoding, and encoding isn't specified as an option in most of the object subcommands, or elsewhere AFAIK.
  • I can't always tell what data format Links should return, or if it ever returns some.

@whyrusleeping
Copy link

to figure out the exact http request used by the ipfs cli, in one terminal run:

nc -l 6000

and in another run the ipfs command you want, with the flag: --api=/ip4/127.0.0.1/tcp/6000

i don't think i've ever used the protobuf encoding... odd, but the encoding option is a global one afaik.

Links should return links? should be an array of link objects.

@daviddias
Copy link
Contributor

I can't figure out how to get object patch to work in curl.

0.4.0 doesn't have object patch anymore, now it has:

    ipfs object patch append-data <root> <data>    - Append data to the data segment of a dag node.
    ipfs object patch add-link <root> <name> <ref> - Add a link to a given object.
    ipfs object patch rm-link <root> <link>        - Remove a link from an object.
    ipfs object patch set-data <root> <data>       - Set data field of an ipfs object.


+ Request With Empty Argument

This, and all calls with options, has the same response as it would if an invalid argument is supplied.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have the same response as it would be if an invalid argument was supplied.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 100% grammatical. :/

@daviddias
Copy link
Contributor

@RichardLitt have you checked #32 (comment) and tried @whyrusleeping suggestion?

@daviddias daviddias mentioned this pull request Feb 23, 2016
41 tasks
@RichardLitt RichardLitt changed the title Add Group object Added Group object Feb 24, 2016
+ `add-link` - with `<name> <ref>`, adds a link to a node
+ `rm-link` - with `<name>`, removes a link from a node
+ `set-data` - sets a node's data
+ `append-data` - appends to a node's data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is 0.3.11 only, in 0.4.0 these args became the name of the commands //cc @dignifiedquire

@RichardLitt
Copy link
Contributor Author

@diasdavid Working on it. Entire patch command needs to be redone.

@fbaiodias
Copy link

@RichardLitt any news on the patch commands? Would be super helpful for ipfs/js-ipfs#58 :)

@RichardLitt
Copy link
Contributor Author

@xicombd I'll prioritize this. Thanks.

@RichardLitt
Copy link
Contributor Author

Kept open for reference. Close when #67 and #68 are merged.

@RichardLitt RichardLitt removed their assignment Mar 15, 2016
@RichardLitt
Copy link
Contributor Author

@RichardLitt
Copy link
Contributor Author

Closing this to stop confusion.

@daviddias daviddias deleted the feature/object branch April 14, 2016 08:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants