Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(retrievalprovider): prioritize announce addresses over host addresses #534

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

yann-y
Copy link

@yann-y yann-y commented Jul 24, 2024

If announce addresses are configured, the retrieval provider now prioritizes these over the addresses directly obtained from the host. This allows fora more controlled announcement of addresses in libp2p networks.

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

…esses

If announce addresses are configured, the retrieval provider now prioritizes
these over the addresses directly obtained from the host. This allows fora more controlled announcement of addresses in libp2p networks.
@simlecode
Copy link
Collaborator

@yann-y Need format code

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 26.28%. Comparing base (44481dd) to head (ca2e095).
Report is 42 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
+ Coverage   25.06%   26.28%   +1.22%     
==========================================
  Files         182      182              
  Lines       22294    17582    -4712     
==========================================
- Hits         5587     4621     -966     
+ Misses      15773    12029    -3744     
+ Partials      934      932       -2     
Flag Coverage Δ
unittests 26.28% <0.00%> (+1.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
retrievalprovider/transports.go 0.00% <0.00%> (ø)

... and 161 files with indirect coverage changes

Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simlecode simlecode merged commit 199cfaf into ipfs-force-community:master Jul 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants