cutoffs parameter has a limit of length 12 in r5, but not documented in r5r

[botanize]

I got the following error when I attempted to provide a vector of 15 cutoff values to the accessibility function: java.lang.IllegalArgumentException: Maximum number of cutoffs allowed in a regional analysis is 12

[rafapereirabr]

Hi @botanize . Thank you for opening the issue. I believe this is hardcoded upstream in R5. Perhaps @mvpsaraiva can confirm that.

[mvpsaraiva]

Interesting, I hadn't noticed that.
Indeed, R5 has a 12 cutoffs maximum hardcoded:

    /**
     * The largest number of cutoffs we'll accept in a regional analysis task. Too many cutoffs can create very large
     * output files. This limit does not apply when calculating single-point accessibility on the worker, where there
     * will always be 121 cutoffs (from zero to 120 minutes inclusive).
     */
    public static final int MAX_REGIONAL_CUTOFFS = 12;

Also, the maximum cutoff allowed is 120 minutes.
We need to document this in the accessibility() function.

[botanize]

I documented and added checks on a branch in my fork, if you want I can create a pull request.

https://github.com/botanize/r5r/tree/cutoffs

[dhersz]

Thank you @botanize. We will be adding this check and relevant documentation on the next version.

[rafapereirabr]

Thank you @botanize . I've now clarified this in the function documentation. This is already available in the dev version and will be included in the next release of r5r on CRAN.