Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detailed_itineraries - function missing a timeout limit #196

Closed
SRN1973 opened this issue Sep 6, 2021 · 3 comments
Closed

detailed_itineraries - function missing a timeout limit #196

SRN1973 opened this issue Sep 6, 2021 · 3 comments

Comments

@SRN1973
Copy link

SRN1973 commented Sep 6, 2021

When I feed a lot ot origin-destination pairs to the detailed_itineraries function I always happen to have some connections to calculate that seem to slow down the overall calculation process quite dramatically (cause the function to run for a few minutes for a few connections out of the data-set). Do you think it would be possible to implement some kind of additional timeout parameter so that if one of the triggered parallel processes takes too long it is terminated automatically, and returns NULL?

@mvpsaraiva
Copy link
Collaborator

That's a very interesting feature, thanks for the suggestion. I'm not sure we can do this without some upstream changes in R5, but I'll take a look.

@mvpsaraiva
Copy link
Collaborator

Hi @SRN1973.

I've checked and we cannot add a timeout limit to detailed_itineraries(), or any of the other of the package's functions, without a lot of work done upstream in R5.
Do you think the new version of travel_time_matrix() that we're preparing (issue #194) provides enough output information that you may be able to use it instead of detailed_itineraries()? It's much faster, and probably will fix some of the issues you had.

@rafapereirabr
Copy link
Member

Unfortunately, this could only be done upstream in R5. If you like the feature, we'd recommend opening a request on R5 github repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants