Add DISK field to biosnoop #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for testing on different platforms. I think the field should be 7-chars wide to match the BCC version, plus as this grows to approach the BCC version (if it does) we should keep the default output <80 chars. |
danobi
reviewed
Jan 5, 2021
casparant
added a commit
to casparant/bpftrace
that referenced
this pull request
Jan 8, 2021
* 'master' of github.com:iovisor/bpftrace: Fixup changelog Add DISK field to biosnoop (bpftrace#1660) tests/childproc: resume SIGHUP to SIG_DFL before test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add disk field to biosnoop.
I tried to also add
req->part->part_nobut I felt I was not getting what I expected on it when writing to certain partitions.Checklist
docs/reference_guide.mdCHANGELOG.md