Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bcc: Use -Werror=undef #5089

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bcc: Use -Werror=undef #5089

wants to merge 1 commit into from

Conversation

ShawnZhong
Copy link
Contributor

@ShawnZhong ShawnZhong commented Aug 24, 2024 •
edited
Loading

Fix #5019

@Bojun-Seo
Copy link
Contributor

How about adding some explanation about this commit in the commit message?
You can write the whole reason in it, or you can just leave a link like this PR description.
(e.g. Fix https://github.com/iovisor/bcc/issues/5019)
I prefer the former by the way.

Bojun-Seo
Bojun-Seo reviewed Aug 28, 2024
View reviewed changes
src/cc/usdt/usdt.cc
@@ -36,15 +36,15 @@ Location::Location(uint64_t addr, const std::string &bin_path, const char *arg_f
: address_(addr),
bin_path_(bin_path) {

#ifdef __aarch64__
#if defined(__aarch64__)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to change #ifdef A into #if defined(A) ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. ifdef -> defined(...) change seems unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bojun-Seo Bojun-Seo Bojun-Seo left review comments

@drzaeus77 drzaeus77 Awaiting requested review from drzaeus77 drzaeus77 is a code owner

@yonghong-song yonghong-song Awaiting requested review from yonghong-song yonghong-song is a code owner

@4ast 4ast Awaiting requested review from 4ast 4ast is a code owner

@davemarchevsky davemarchevsky Awaiting requested review from davemarchevsky davemarchevsky is a code owner

@goldshtn goldshtn Awaiting requested review from goldshtn goldshtn is a code owner

@brendangregg brendangregg Awaiting requested review from brendangregg brendangregg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use -Werror=undef when compiling bcc to catch issues when a macro is not defined.
3 participants
@ShawnZhong @Bojun-Seo @yonghong-song