Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[config] remove global EvmNetworkID #3502

Closed
2 tasks done
dustinxie opened this issue Jul 5, 2022 · 0 comments · Fixed by #3503
Closed
2 tasks done

[config] remove global EvmNetworkID #3502

dustinxie opened this issue Jul 5, 2022 · 0 comments · Fixed by #3503
Assignees
@millken
Labels
refactor

Comments

@dustinxie
Copy link
Member

Description of the code refactor

after 2 PR to handle EvmNetworkID in blockdao and consensus package, we can finally:

  1. remove SetEVMNetworkID() and EVMNetworkID() from config package
  2. remove all usage of these 2 from entire codebase

Why is this needed

  • [] better/less memory usage
  • [] reduce running time
  • [] clean (easy-to-understand) data structure or algorithm
  • remove dead code
  • [] better code design or structure (like reduce complexity)
  • reduce/decouple dependencies between code modules
  • [] increase test coverage
  • [] better code readability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@millken millken

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[config] remove unused EvmNetworkID(),SetEVMNetworkID()
2 participants
@millken @dustinxie