Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ioctl] refactor nodereward command in new ioctl #3280

Closed
huof6829 opened this issue Apr 11, 2022 · 0 comments · Fixed by #3416
Closed

[ioctl] refactor nodereward command in new ioctl #3280

huof6829 opened this issue Apr 11, 2022 · 0 comments · Fixed by #3416
Labels
good first issue Good for newcomers

Comments

@huof6829
Copy link
Contributor

What would you like to be added

Notes:

  1. Use function of client interface .
  2. Output package is deprecated. e.g. output.PrintError could be replaced with errors.Wrap.
  3. Global variables (config.ReadConfig config.DefaultConfigFile etc.) have been wrapped into client interface. Please use client interface to access them if needed
  4. The logic of new code should be similar to the old one.
  5. In each unit test, the results should be checked whether they are as the expected.

Example:

  1. https://github.com/iotexproject/iotex-core/blob/master/ioctl/newcmd/account/accountinfo.go
  2. https://github.com/iotexproject/iotex-core/blob/master/ioctl/newcmd/account/accountdelete.go
  3. https://github.com/iotexproject/iotex-core/blob/master/ioctl/newcmd/account/accountcreateadd.go

Why is this needed

Unit tests couldn't be added for the old ioctl command (./ioctl/cmd)

@huof6829 huof6829 added the enhancement New feature or request label Apr 11, 2022
@huof6829 huof6829 added good first issue Good for newcomers and removed enhancement New feature or request labels Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant